Skip to content
This repository has been archived by the owner on Apr 5, 2018. It is now read-only.

Update gyp to latest #9

Closed
wants to merge 1 commit into from
Closed

Conversation

implausible
Copy link
Contributor

Hey, was working with pangyp and noticed that internally, gyp is 2 years old. Needed --no-duplicate-basename-check from the latest build of gyp.

Sidenote: How can I pass this flag into pangyp configure

@JCMais
Copy link

JCMais commented Aug 11, 2015

@rvagg Can you please check this?

It's also needed to compile under Visual Studio 2015.

@rvagg
Copy link
Owner

rvagg commented Aug 11, 2015

sorry about the delay, pangyp is low priority for me as it was only ever meant to be temporary, will merge and release with a minor bump now.

@am11
Copy link
Contributor

am11 commented Aug 29, 2015

👍
This is also blocking me building node-sass binaries using VS2015.

@JCMais
Copy link

JCMais commented Aug 30, 2015

AFAIK, this was already merged, but @rvagg / @implausible forgot to close this pr.

See commit 6b1641b

@rvagg rvagg closed this Aug 30, 2015
@am11
Copy link
Contributor

am11 commented Aug 30, 2015

@JCMais, thanks! Took a closer look, node_modules/.bin/pangyp rebuild after npm install --msvs_version=2015 indeed generates VS2015 .vcxproj, but the build script spawns the wrong msbuild version (it blindly selects the one it finds in PATH), instead of matching the version of Toolset the project file is requiring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants