Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Image Proxy breaking Nodei.co images in markdown #9

Closed
Glavin001 opened this issue Jan 29, 2014 · 19 comments
Closed

GitHub Image Proxy breaking Nodei.co images in markdown #9

Glavin001 opened this issue Jan 29, 2014 · 19 comments

Comments

@Glavin001
Copy link

It appears that after GitHub's release for proxying user images my new projects and Nodei.co badges no longer are working.

Example:

Nodei.co (working):

https://nodei.co/#feathers-mongoose-service

Project README (not working):

https://github.com/Glavin001/feathers-mongoose-service

Markdown (used in README):

NPM

Link to Image, as used in Markdown (working)

https://nodei.co/npm/feathers-mongoose-service.png?downloads=true&stars=true


This may because GitHub's new proxy is not caching properly? They stated that this change would provide fewer broken images in the future although it appears to be causing more.

Is anyone else having this problem? Is there a workaround solution? This is likely a GitHub issue that needs to be fixed, but I wanted to get some feedback here before I contact GitHub support.


I really love using Nodei.co! Thank you for such a simple, yet awesome project.

@rvagg
Copy link
Owner

rvagg commented Jan 29, 2014

I honestly don't know what the status of this is, a real mess. @feross was investigating and I think the current conclusion is that some repos will have broken images which have been cached and will be broken until removed from whatever cache they are stuck in. Other repos seem to pass through to nodei.co without touching fastly.

Also see twitter rants where @holman has been pulled in, he seems to be the lightening-rod for this since it was his post that introduced the change and perhaps he's responsible for this new functionality.

@feross
Copy link

feross commented Jan 29, 2014

Twitter conversation here: https://twitter.com/feross/status/428435981516038144

@rvagg
Copy link
Owner

rvagg commented Jan 29, 2014

For the record, we've had cache-control: no-cache on nodei.co badges from the beginning.

@holman
Copy link

holman commented Jan 29, 2014

Do any of you have a thread going with support on this?

@rvagg
Copy link
Owner

rvagg commented Jan 29, 2014

@holman not I, twitter is the venting medium of choice on this one

@Glavin001
Copy link
Author

Thank you for your prompt reply, @rvagg. While I am glad I am not the only one, I really hope this can be resolved soon for everyone affected.
And thanks for sharing the link, @feross.

@holman, is there anything we can do to help quicken GitHub's debugging process? Or is there an already known bug that is in progress?

@holman
Copy link

holman commented Jan 29, 2014

@holman, is there anything we can do to help quicken GitHub's debugging process?

Yup; shoot an email to [email protected] with some of these details.

@Glavin001
Copy link
Author

Will do now.

@feross
Copy link

feross commented Jan 29, 2014

@substack sent an email to support yesterday but I don't know the
current status
of that.

On Wednesday, January 29, 2014, Glavin Wiechert [email protected]
wrote:

Will do now.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-33643549
.

Feross
✩ blog http://feross.org/ | ✎ studynotes http://www.apstudynotes.org/ |☮
webtorrent http://webtorrent.io/

@mcollina
Copy link

mcollina commented Feb 3, 2014

Any update on this? Mosca has its badges broken.

@rvagg
Copy link
Owner

rvagg commented Feb 3, 2014

@mcollina can you try appending some ?garbage to the end of the urls and see if that helps?

@mcollina
Copy link

mcollina commented Feb 3, 2014

I tried in the 'edit preview' and it does not help at all.

@DamonOehlman
Copy link

Did @substack get a response from github at all, like @mcollina I've got broken badges all over the place :(

I'm assuming projects like hapi still have a valid badge because they haven't pushed an update to the README since the github changes?

@subfuzion
Copy link

I tried adding to force it to requery by adding ?version=2 last week and it
didn't do any good

@rvagg
Copy link
Owner

rvagg commented Feb 4, 2014

I believe that this may be rectified now; I set a more explicit certificate chain and switched to the same cert provider as testling uses cause their badges are working.

@subfuzion
Copy link

Awesome -- actually, I didn't have to do anything -- you apparently
resolved the issue with either the cert chain or by switching cert
providers. Thanks!

@mcollina
Copy link

mcollina commented Feb 4, 2014

Awesome! It works perfectly now!

@DamonOehlman
Copy link

Yeah, same for me here - thanks @rvagg for implementing a workaround :)

@Glavin001
Copy link
Author

👍 All fixed here, too! Thank you, @rvagg!

I see this as being closed. Please reopen if the fix by @rvagg did not work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants