-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Image Proxy breaking Nodei.co images in markdown #9
Comments
I honestly don't know what the status of this is, a real mess. @feross was investigating and I think the current conclusion is that some repos will have broken images which have been cached and will be broken until removed from whatever cache they are stuck in. Other repos seem to pass through to nodei.co without touching fastly. Also see twitter rants where @holman has been pulled in, he seems to be the lightening-rod for this since it was his post that introduced the change and perhaps he's responsible for this new functionality. |
Twitter conversation here: https://twitter.com/feross/status/428435981516038144 |
For the record, we've had |
Do any of you have a thread going with support on this? |
@holman not I, twitter is the venting medium of choice on this one |
Thank you for your prompt reply, @rvagg. While I am glad I am not the only one, I really hope this can be resolved soon for everyone affected. @holman, is there anything we can do to help quicken GitHub's debugging process? Or is there an already known bug that is in progress? |
Yup; shoot an email to [email protected] with some of these details. |
Will do now. |
@substack sent an email to support yesterday but I don't know the On Wednesday, January 29, 2014, Glavin Wiechert [email protected]
Feross |
Any update on this? Mosca has its badges broken. |
@mcollina can you try appending some ?garbage to the end of the urls and see if that helps? |
I tried in the 'edit preview' and it does not help at all. |
I tried adding to force it to requery by adding ?version=2 last week and it |
I believe that this may be rectified now; I set a more explicit certificate chain and switched to the same cert provider as testling uses cause their badges are working. |
Awesome -- actually, I didn't have to do anything -- you apparently |
Awesome! It works perfectly now! |
Yeah, same for me here - thanks @rvagg for implementing a workaround :) |
It appears that after GitHub's release for proxying user images my new projects and Nodei.co badges no longer are working.
Example:
Nodei.co (working):
https://nodei.co/#feathers-mongoose-service
Project README (not working):
https://github.com/Glavin001/feathers-mongoose-service
Markdown (used in README):
Link to Image, as used in Markdown (working)
https://nodei.co/npm/feathers-mongoose-service.png?downloads=true&stars=true
This may because GitHub's new proxy is not caching properly? They stated that this change would provide fewer broken images in the future although it appears to be causing more.
Is anyone else having this problem? Is there a workaround solution? This is likely a GitHub issue that needs to be fixed, but I wanted to get some feedback here before I contact GitHub support.
I really love using Nodei.co! Thank you for such a simple, yet awesome project.
The text was updated successfully, but these errors were encountered: