Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional LED examples #31

Closed
wants to merge 3 commits into from
Closed

Conversation

Resseguie
Copy link
Collaborator

Tweaked led-rgb.js to be consistent var names and quotes.
Added led-rainbow from J5 examples.
Combined other single-led J5 examples into one temporal-based example in led.js.

@rwaldron
Copy link
Owner

rwaldron commented Jun 6, 2014

@Resseguie This is failing in travis, please fix https://travis-ci.org/rwaldron/spark-io/builds/26903799

pins: {
red: "A5",
red: "A5",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whitespace is going to kill me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mental note: no vertical aligning of option values. :)

@Resseguie
Copy link
Collaborator Author

See rwaldron/johnny-five#377 for the related PR on Johnny Five

@rwaldron
Copy link
Owner

rwaldron commented Jun 6, 2014

I've just published a new release to npm with all of your latest examples

@Resseguie
Copy link
Collaborator Author

I included examples from this PR in my latest #36 PR. Closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants