Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drag drop selection #158

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix drag drop selection #158

wants to merge 6 commits into from

Conversation

SwissalpS
Copy link
Contributor

provides:

  • drag and drop of selected text (in same document)
  • LMB+drag selected text to move it elsewhere
  • or LMB on selection and then LMB at destination (if sticky is enabled)
  • hold ctrl on release to copy selection
  • press escape to abort

changes:

  • (regretably) dragged selection is no longer deleted when drag starts
    this follows procedure that most editors use.
  • ctrl is checked on release, previously on drag-start/mouse-down
  • added sticky mode to help against finger strain from holding mouse
    button during entire drag procedure
  • moved/copied portion is now selected after operation
  • during drag operation an extra caret is shown to indicate exact
    insertion location and real caret is not blinking
  • adds commands to toggle sticky mode and entire plugin

@SwissalpS
stage one: non sticky basics work
76216f8 
- need to add caret while dragging so user knows perfectly where text
will be inserted
- need to add sticky mode properly
- test that holding two buttons and releasing right doesn't mess things
up
@SwissalpS
trivial changes
f4347ec 
mainly adapting to same wording as used in lite-xl version
@SwissalpS
stage two: move and copy now work in both modes
fadad51 
selection is set after operation
@SwissalpS
stage three: add insertion caret during drag
10dd429
@SwissalpS
stage four: cleanup
d2a6b0b
@SwissalpS
credits
74390c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SwissalpS