Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to rxdart 0.28.0 #135

Conversation

arturograu
Copy link

@arturograu arturograu commented Jun 25, 2024

Upgraded to rxdart since the apps that have installed the 0.28.0 cannot compile if are depending on this package.
Closes #134

just_audio: ^0.9.31
just_audio:
git:
url: [email protected]:arturograu/just_audio.git
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only way to make the example compile since just_audio depends on audio_session. So audio_session cannot be upgraded to rxdart 0.28.0 until just_audio upgrades.

I suggest creating a pre-release with the content of this PR so we can upgrade just_audio at least depending on this pre-release. Then we can change this dependency back into the official just_audio and do the official release.

@ryanheise
Copy link
Owner

Hi @arturograu . Thanks for working on a PR, although it has a few issues that would prevent me from merging it:

  • includes changes to iOS configuration files which are not pertinent to the rxdart fix.
  • you have increased the lower bound for the rxdart constraint unnecessarily. We want to be able to support the whole range from the lowest possible version rxdart to the highest possible version of rxdart. You can see this approach from the existing code.

I will work on a fix.

@ryanheise
Copy link
Owner

v0.1.20 is now published bumping the upper bound of the rxdart constraint.

@ryanheise ryanheise closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rxdart 0.28.0
2 participants