Power Line half cirles streched #658
Comments
|
Hmm, your symbols look more distorted than encoded:
These round Powerline Things were never half-circles, half-circles would look to small, that is the reason why they were designed to be more elliptic than round. |
|
Ah, I see the problem, it is in the
|
|
I'm not really sure the |
|
Working on this right now.... By the side: How bad is that, the source of the rounded things already has them ... strangely placed:
The 'full' blob is a bit higher than the 'line'. Pink rectangulars added with my screenshot tool. |
|
😭 WTF
Not only are the 'line' things further down then the 'full' things (but at least both pairs are equal!), but the round-on-left LINE is right aligned as the FULL, making it considerably more rightish that expected. |
[why]
The powerline glyphs (and only them) undergo a xy scaling, where both
dimensions are maximized into the 'cell'.
Normally cells are taller than wide, and everyting looks fine. But we
have square cells (e.g. 2048 * 2048) with the SymbolsOnly font, and
there might be some self patched font that has similar very-wide (in
comparison to hight) cells.
In these fonts some powerline glyphs look rather ugly. For example the
'half cicles' become very wide and un-round, the triangulars become very
pointy.
[how]
Add a new patch-set attribute 'xy-ratio'. When that is set the vertical
(y) scaling is done as usual but the horizontal (x) scaling is limited
such that the width/height ratio is maximally the attributes value.
For example setting it to 0.75 the height is maximized (as usual) but
the width is maximized to be less then 0.75 times the hight (or as wide
as the cell is, whatever is smaller).
It will work with both, 'xy' and 'pa' scaling, at least theoretically.
It has been only checked where it is used now, i.e. with 'xy'.
A possible overlap is not taken into account.
[note]
The values are taken for this reasons:
- 0.59: This is the original half-circle ratio, higher values make them
loose the (half) circular appearance
- 0.5: The half circle lines are more shallow
- 0.7: The triangulars should not be too pointy (random number)
Fixes: #658
Signed-off-by: Fini Jastrow <[email protected]>
|
This was a tough one, but I think the solution is rather nice. It was about the 4th or 5th different approach. I guess the new code describes best what we want to achieve here. Thanks for reporting! |
|
Sorry for the late reply, the only email message from GitHub that I got was from the closing of the issue. Thanks for fixing it though. Your work is much appreciated |
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why]
The powerline glyphs (and only them) undergo a xy scaling, where both
dimensions are maximized into the 'cell'.
Normally cells are taller than wide, and everyting looks fine. But we
have square cells (e.g. 2048 * 2048) with the SymbolsOnly font, and
there might be some self patched font that has similar very-wide (in
comparison to hight) cells.
In these fonts some powerline glyphs look rather ugly. For example the
'half cicles' become very wide and un-round, the triangulars become very
pointy.
[how]
Add a new patch-set attribute 'xy-ratio'. When that is set the vertical
(y) scaling is done as usual but the horizontal (x) scaling is limited
such that the width/height ratio is maximally the attributes value.
For example setting it to 0.75 the height is maximized (as usual) but
the width is maximized to be less then 0.75 times the hight (or as wide
as the cell is, whatever is smaller).
It will work with both, 'xy' and 'pa' scaling, at least theoretically.
It has been only checked where it is used now, i.e. with 'xy'.
A possible overlap is not taken into account.
[note]
The values are taken for this reasons:
- 0.59: This is the original half-circle ratio, higher values make them
loose the (half) circular appearance
- 0.5: The half circle lines are more shallow
- 0.7: The triangulars should not be too pointy (random number)
Fixes: ryanoasis#658
Signed-off-by: Fini Jastrow <[email protected]>
Powerline symbols are Streched (horizontally)
Im trying to use the powerline symbols U+E0B6 and U+E0B4
★ Optional
two "half circles" should create a cirle ? (the "blob" on the right are the two half circles)
The text was updated successfully, but these errors were encountered: