font-patcher: Make sure nf-custom-asm and nf-custom-v_lang icons are included #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the nice PR! 👍 |
|
Maybe we should do something to prevent this in the future. One of, maybe
What do you think? |
|
I think @all-contributors should add @teatimeguest for code. |
|
I've put up a pull request to add @teatimeguest! 🎉 |
|
Thank you for your quick response and merging! I think it would be very helpful to contribute if there are brief instructions or checklists in (Or, it might be best if CI could detect some inconsistencies between source files, if possible.) |
|
Well, maybe it is intentional that adding a new glyph to the core set is hard. Because a better solution is always to get the new glyph accepted at some of the upstream symbol collection projects. One reason for that is that the codepoints that are left are dwindling away.
Well, by not specifying the end codepoint we would just patch in all codepoints. |
Finii
added a commit
that referenced
this pull request
Feb 13, 2023
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR #1119 Signed-off-by: Fini Jastrow <[email protected]>
2 tasks
Finii
added a commit
that referenced
this pull request
Feb 13, 2023
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR #1119 Signed-off-by: Fini Jastrow <[email protected]>
Finii
added a commit
that referenced
this pull request
Feb 13, 2023
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR #1119 Signed-off-by: Fini Jastrow <[email protected]>
Finii
added a commit
that referenced
this pull request
Feb 13, 2023
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR #1119 Signed-off-by: Fini Jastrow <[email protected]>
Finii
added a commit
to b-/nerd-fonts
that referenced
this pull request
Feb 17, 2023
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR ryanoasis#1119 Signed-off-by: Fini Jastrow <[email protected]>
scottames
referenced
this pull request
in scottames/dots
May 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ryanoasis/nerd-fonts](https://togithub.com/ryanoasis/nerd-fonts) | major | `v2.3.3` -> `v3.0.0` | --- ### Release Notes <details> <summary>ryanoasis/nerd-fonts</summary> ### [`v3.0.0`](https://togithub.com/ryanoasis/nerd-fonts/releases/tag/v3.0.0) [Compare Source](https://togithub.com/ryanoasis/nerd-fonts/compare/v2.3.3...v3.0.0) ***Update: Preparation already for a bugfix release, see known bugs [here](https://togithub.com/ryanoasis/nerd-fonts/milestone/26)*** This major release introduces some breaking changes: ##### Breaking 1: Naming This release fixes some long standing issues that are due to the naming of the fonts: There is a completely new naming scheme. This might be inconvientient for existing setups, sorry. - Some fonts will have `Nerd Font` in the name while other have it abbreviated as `NF`. This is needed because some names just were too long. (Same for `Nerd Font Mono` and `NFM`.) - There are no `Windows Compatible` fonts anymore. All fonts work on all platforms. - The `Complete` from the font names (and the repo directories) has been dropped (Complete is the new normal). - The name parts will be ordered as expected with style and weight last (`Somefont Bold Nerd Font` -> `Somefont Nerd Font Bold`). - The filename will have no blanks anymore. ##### Breaking 2: Material Design Icons Codepoints The old Material Design Icon codepoints are finally dropped. Due to an historic mistace we placed them in between some asiatic glyphs, breaking that script. Since v2.3.0 the (updated and expanded) Material Design Icons have new codepoints in the 5 digit region. - Dropped codepoints `F500`... and class names `nf-mdi-*` - New codepoints `F0001`... and class names `nf-md-*` (already since `v2.3.0`) - The whole discussions are here: [https://github.com/ryanoasis/nerd-fonts/issues/365](https://togithub.com/ryanoasis/nerd-fonts/issues/365) - A translation table is available here: [https://github.com/ryanoasis/nerd-fonts/issues/1059#issuecomment-1404891287](https://togithub.com/ryanoasis/nerd-fonts/issues/1059#issuecomment-1404891287) - There are tools out there that probably can update your configuration. - Relevant thread: [#​1190](https://togithub.com/ryanoasis/nerd-fonts/issues/1190) Otherwise this is a 'Update release', so now the good stuff: ##### Updates - Update `Agave` to v37 - Update `Arimo` to 1.33 - Update `DaddyTimeMono` to 1.2.3 - Update `Fira Mono` to 3.206 - Update `Go Mono` to 2.010 - Update `Hermit` to 2.0 - Update `IBM Plex` to 2.3 - Update `Iosevka` to 22.1.0 - Update `Literation` to 2.1.5 - Update `Lilex` to 2.000 - Update `mononoki` to 1.6 - Update `MPlus` to ... current - Update `Overpass` to 3.0.5 - Update `Roboto Mono` to 3.0 - Update `Source Code Pro` to 2.038 - Update `Terminus` to 4.49.2 - Update `Victor Mono` to 1.5.4 - Update the Octicons set to 18.3.0 ##### Features - New font `ComicShannsMono` - New variant in release `Nerd Font Propo` for GUI usecases - Patch in heavy angle brackets - Patch in boxdrawing glyphs (if the font has no complete set) - Repair Panose info if source font has broken data - Reform PowerlineExtra sizing - Autocreate a `FontPatcher.zip` from `HEAD` - Create a json database with css names - Disentangle `Iosevka` into two packets (one for `Iosevka Term`) - Add option to manipulate `xAvgCharWidth` (needed rarely by self-patchers) - Add option to allow italic-less fonts with oblique - Add `--debug` and `--dry` to `font-patcher` - Add logging into file to `font-patcher` - Add `NERDFONTS` environment variable to transport options through `gotta-patch-em` ##### Improvements - Fix `Caskaydia Code` height different to `Cascadia Code` (hinting problem) (font is now `ttf` instead of `otf`!) ##### Fixes - Fix baseline to basline distance (line gap) for some fonts - Fix weather icons cloud scaling - Fix UniqueID of the fonts - Fix `Bitstream Vera` name: Is now `Bitstrom Wera` due to licensing issue - No fix, but: Drop support for Python 2 #### New Contributors - [@​Goooler](https://togithub.com/Goooler) made their first contribution in [https://github.com/ryanoasis/nerd-fonts/pull/1079](https://togithub.com/ryanoasis/nerd-fonts/pull/1079) - [@​MicaelJarniac](https://togithub.com/MicaelJarniac) made their first contribution in [https://github.com/ryanoasis/nerd-fonts/pull/1100](https://togithub.com/ryanoasis/nerd-fonts/pull/1100) - [@​teatimeguest](https://togithub.com/teatimeguest) made their first contribution in [https://github.com/ryanoasis/nerd-fonts/pull/1119](https://togithub.com/ryanoasis/nerd-fonts/pull/1119) - [@​b-](https://togithub.com/b-) made their first contribution in [https://github.com/ryanoasis/nerd-fonts/pull/1044](https://togithub.com/ryanoasis/nerd-fonts/pull/1044) - [@​Weltolk](https://togithub.com/Weltolk) made their first contribution in [https://github.com/ryanoasis/nerd-fonts/pull/1163](https://togithub.com/ryanoasis/nerd-fonts/pull/1163) - [@​sullrich84](https://togithub.com/sullrich84) made their first contribution in [https://github.com/ryanoasis/nerd-fonts/pull/1166](https://togithub.com/ryanoasis/nerd-fonts/pull/1166) **Full Changelog**: ryanoasis/nerd-fonts@v2.3.3...v3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR ryanoasis#1119 Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
nf-custom-asmandnf-custom-v_langicons are present in the css file and database script, but not in any patched fonts. Also, in the cheat sheet they are displayed as blank rectangles since glyphs are not available (see below).This PR fixes the
font-patcherscript to include these glyphs in font.Requirements / Checklist
Screenshots (if appropriate or helpful)