Add glyph for fennel #1129
Merged
Add glyph for fennel #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anything else needed on my end, or is it just a waiting game until a bunch of changes are batched up for a new release? |
|
/me working hard to get overdue |
|
Right on! No rush, I just wanted to make sure you weren't waiting on me. Thank you! |
|
Anything I can do to help get this included in the next release? |
|
Thanks for the PR! Sorry for the long wait. Small problem, overlapping path not handled correctly, fixing...
|
[why] Fonts can only work with paths. The svg has strokes and objects that render incorrect. [how] Convert everything to path than combine all paths. Signed-off-by: Fini Jastrow <[email protected]>
|
Rebase on master, force push. |
|
@allcontributors please add @Grazfather for code or design or whatever ;) |
|
I've put up a pull request to add @Grazfather! 🎉 |
|
Whoa! Thank you, and sorry for the trouble with the SVG. Thanks for fixing it for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fennel is a popular lisp-like lang that compiles to Lua. See fennel-lang.org.
The logo is CC-BY-SA 4.0.
Attached is a monochrome svg by @m455 (+thanks to @eccentric-j for converting to monochrome), but I can look into converting it properly using IcoMoon.
Requirements / Checklist
What does this Pull Request (PR) do?
Adds a single glyph for the fennel-lang logo
How should this be manually tested?
Verify glyph shows up in patched fonts
Any background context you can provide?
What are the relevant tickets (if any)?
See bakpakin/Fennel#438
Screenshots (if appropriate or helpful)