Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Codicon Circles #1261

Merged
merged 3 commits into from
May 30, 2023
Merged

Bugfix Codicon Circles #1261

merged 3 commits into from
May 30, 2023

Commits on May 30, 2023

  1. font-patcher: Add ScaleGroupVert 

    Codicons: Maximise all circles

[why]
The scaling works okay for `Nerd Font Mono` fonts, but not for `Nerd Font`
fonts. The later have 'unexpected' left side bearing, which looks even
more out of place because the width is unrelated to the advance width
and might place the majority of the glyph into the next cell.

[how]
In fact we do not want scaling and shifting to be uniform for all glyphs
but the intend was to get the scaling from the biggest (full size)
circle and all the smaller ones would be proportionally smaller.

So we add a new Scale grouping that just takes the scale and the
vertical shift of the combined boundingbox, but individually calculates
the horizontal shift.

Signed-off-by: Fini Jastrow <[email protected]>
    @Finii
    Finii committed May 30, 2023
    Configuration menu
    Copy the full SHA
    fcf5c84 View commit details
    Browse the repository at this point in the history

  2. Codicons: Revert to no Scale grouping 

    See PR #1261 for details on the reasons.

This mostly reverts commit
  f84a4a4  font-patcher: Add Codicons scale list

Signed-off-by: Fini Jastrow <[email protected]>
    @Finii
    Finii committed May 30, 2023
    Configuration menu
    Copy the full SHA
    c8dd880 View commit details
    Browse the repository at this point in the history

  3. Revert "font-patcher: Add ScaleGroupVert" 

    This reverts commit fcf5c84.

[why]
There is no current usecase for the ScaleGroupVert.
    @Finii
    Finii committed May 30, 2023
    Configuration menu
    Copy the full SHA
    f3f8da1 View commit details
    Browse the repository at this point in the history