Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Iosevka variants to version 29.0.4 #1497

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Update all Iosevka variants to version 29.0.4 #1497

merged 2 commits into from
Mar 30, 2024

Conversation

iruoy
Copy link
Contributor

@iruoy iruoy commented Jan 26, 2024

Description

Bring all Iosevka versions up to date

Requirements / Checklist

What does this Pull Request (PR) do?

  • Update Iosevka to version 28
  • Update the filenames since they're now in CamelCase

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@iruoy iruoy marked this pull request as ready for review January 26, 2024 23:41
@Finii Finii added this to the v3.2.0 milestone Jan 28, 2024
@Finii
Copy link
Collaborator

Finii commented Jan 28, 2024

Thanks for the nice PR!

I would put this on hold until directly before the Nerd Fonts v3.2 release, as there might be another Iosevka release in between.

And then one question:
You put all the weights into individual directories for IosevkaTermSlab, where it was one big flat directory before.
Is there a reason for that, except because the other Iosevkas have it and you wanted to unify?

Do you download the fonts from the website for installation?

The flat setup in the newer variant - do you see advantages in the 'deep' setup?

My reasoning was that grouping by weight is not very useful, as people usually want all weights but only one variant (Mono, Propo). Did not finish that redesign, but that is where the flat source (and patched) directories come from.

What I mean:

.../patched_fonts/
                  Iosevka/
                          Nerd Font/         (all the weights, flat)
                          Nerd Font Mono/    (all weights, flat)
                          Nerd Font Propo/   (you get the idea)

In the release packages they are always flat anyhow.

@iruoy
Copy link
Contributor Author

iruoy commented Jan 29, 2024

Hey, thanks for your extensive comment.

First off, I think it's a good idea to hold off on merging this until right before a new version is tagged, because Iosevka releases so often. There's even been a new release since I made this PR.

The reason for the changes to IosevkaTermSlab was indeed to synchronize the workflow across the three Iosevka folders. I still think that's a good thing to do. Apparently, I settled on the wrong concept though. Tomorrow, I'll try to wrangle these configs into generating the folder structure you're looking for.

@Finii
Copy link
Collaborator

Finii commented Jan 29, 2024

I still think that's a good thing to do.

What do you mean by 'it'? Unifying or having a deep-weights-directory-structure?
If the second, can you explain? Just because I once thought it (*) would be a good idea does not make it the best solution.
Every discussion welcome.

Edit: (*) This it means a-flat-structure

@Finii
Copy link
Collaborator

Finii commented Mar 30, 2024

Updated this PR to use 29.0.4 which is current.
Also drop patched fonts, these are created by the release process.
Also some small other changes.

@Finii Finii added the Ready ⛱ Ready to merge but waiting to be merged near a release label Mar 30, 2024
@Finii
Copy link
Collaborator

Finii commented Mar 30, 2024

@allcontributors please add @iruoy for code

Copy link
Contributor

@Finii

I've put up a pull request to add @iruoy! 🎉

@Finii Finii changed the title Update all Iosevka variants to version 28 Update all Iosevka variants to version 29.0.4 Mar 30, 2024
iruoy and others added 2 commits March 31, 2024 00:20
Sqashed these commits:

* Remove Thin, Extra-Light, Semi-Bold and Heavy variants of IosevkaTermSlab
* Remove Thin, Extra-Light, Semi-Bold and Heavy files after unpacking
* No more subfolders per weight
* Revert commiting patched fonts
* Rewrite update scripts
* Update readme.md
[why]
When we drop the subdirectories we probably need to clean
up the patched-fonts directory first, or the old font will
not be overwritten.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii merged commit cff8195 into ryanoasis:master Mar 30, 2024
1 check was pending
@iruoy iruoy deleted the iosevka-28 branch April 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❲Aa❳ update font version bump Ready ⛱ Ready to merge but waiting to be merged near a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants