-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all Iosevka variants to version 29.0.4 #1497
Conversation
Thanks for the nice PR! I would put this on hold until directly before the Nerd Fonts v3.2 release, as there might be another Iosevka release in between. And then one question: Do you download the fonts from the website for installation? The flat setup in the newer variant - do you see advantages in the 'deep' setup? My reasoning was that grouping by weight is not very useful, as people usually want all weights but only one variant (Mono, Propo). Did not finish that redesign, but that is where the flat source (and patched) directories come from. What I mean:
In the release packages they are always flat anyhow. |
Hey, thanks for your extensive comment. First off, I think it's a good idea to hold off on merging this until right before a new version is tagged, because Iosevka releases so often. There's even been a new release since I made this PR. The reason for the changes to |
What do you mean by 'it'? Unifying or having a deep-weights-directory-structure? Edit: (*) This it means a-flat-structure |
Updated this PR to use 29.0.4 which is current. |
@allcontributors please add @iruoy for code |
I've put up a pull request to add @iruoy! 🎉 |
Sqashed these commits: * Remove Thin, Extra-Light, Semi-Bold and Heavy variants of IosevkaTermSlab * Remove Thin, Extra-Light, Semi-Bold and Heavy files after unpacking * No more subfolders per weight * Revert commiting patched fonts * Rewrite update scripts * Update readme.md
[why] When we drop the subdirectories we probably need to clean up the patched-fonts directory first, or the old font will not be overwritten. Signed-off-by: Fini Jastrow <[email protected]>
Description
Bring all Iosevka versions up to date
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)