-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font Zed Mono #1504
Add font Zed Mono #1504
Conversation
I will add some screenshots once I get this working, right now the script is giving me an error:
Anything wrong with my PR? I did add many subdirectories under Edit: Seems like this is the issue: #1505 Using the docker method now: docker run --rm -v "${PWD}/src/unpatched-fonts/ZedMono:/in:Z" -v "${PWD}/patched-fonts/ZedMono:/out:Z" nerdfonts/patcher --complete --makegroups 4 I'm not sure of the correct way to arrange these subfolders, so let me know if anything needs to change. |
81805d0
to
e738a4e
Compare
@Finii let me know if there are any changes I need to make here. |
@cabrinha Thanks for working on this! |
@cabrinha Thanks for working on this! Still waiting for this to be released haha. Zed Mono has become my favorite font. I'm planning to just use this PR and install the fonts from there. Do I need to run anything (run a build or something) or will the patched |
@arlyon So it works. Even works for the native MacOS Terminal (It has no fallback fonts unlike VSCode). Also got it to work on VSCode. By the way, Steps I did to get this:
|
Thanks for the PR! Well, what is special with this font, as we have some Iosevkas already? arlyon commented:
And
Better be! If the patch would not work that would be a bug in the Nerd Font patcher that needs fixing :-> This font seems to have some interest, but to consider it someone should point out the advantages/differences to a regular Iosevka. Btw 'extended', iirc there is a feature request to include some Iosevka extended for the same reason as Blankeos'. |
The font bundled in zed does look nicer (imo) than iosevka. It's a little wider but I have not managed to get them to look the same in my editor. For a comparison compare the first screenshot in my first comment with the others. |
@cabrinha I'm getting this issue with the font currently. Italic variant of It seems to use
|
Resolved conflicts. Let me know if there is anything else I need to do to get this merged @Finii |
Rebase on master, force push. There are some errors in the font database file Are really all these versions needed?
Edit: I must admit I'm not very convinced that this font should be included. |
Well, you need to specify the Family Name of the font, as it says in the option. |
My mistake, there is no problem |
This squashes also these commits: * ds-store * ZedMono: Clean up files Remove files that should not be in the PR, because they are autocreated or belong somewhere else. * Also divide Extended and non-Extended versions. * ZedMono: Fix metadata * ZedMono: Fix some metadata * ZedMono: Drop some more exotic weights and restructure dirs Signed-off-by: Fini Jastrow <[email protected]>
Hmm, I don't get it before the commit above: here the order is ok
and here it is not
Need to investigate that more... |
Hmm. known_widths = { # can take modifiers
'Compressed': ('Cm', 'Comp'),
'Extended': ('Ex', 'Extd'),
'Condensed': ('Cn', 'Cond'),
'Narrow': ('Nr', 'Narrow'),
'Compact': ('Ct', 'Compact'),
} All other fonts we patch that have a width specifier have that width first in their name. Examples
Counterexample
|
[why] When we add a dummy we need to remove that later on. Originally that has been introduces to avoid a wrong code duplication warning. See how the blank leaks into the name: ERROR: ====-< Family (ID 1) too long (38 > 31): ZedMono Nerd Font Extended ExtraBold DEBUG: =====> SubFamily (ID 2) ok ( 6 <=31): Italic DEBUG: =====> Fullname (ID 4) ok (45 <=63): ZedMono Nerd Font Extended ExtraBold Italic DEBUG: =====> PSN (ID 6) ok (33 <=63): ZedMonoNF-ExtendedExtraBoldItalic DEBUG: =====> PrefFamily (ID 16) ok (17 <=31): ZedMono Nerd Font DEBUG: =====> PrefStyles (ID 17) ok (27 <=31): Extended ExtraBold Italic DEBUG: =====> PrefStyles (ID 17) ok (27 <=31): Extended ExtraBold Italic DEBUG: =====> Filename 'ZedMonoNerdFont-ExtendedExtraBoldItalic.ttf' (Note trailing blanks even in ID 1.) Signed-off-by: Fini Jastrow <[email protected]>
[why] Usually we want the width before the weight: ZedMono Nerd Font Extended ExtraBold Italic but we get: ZedMono Nerd Font ExtraBold Extended Italic The reason is that we do not sort widths and weights and handle them as one list, keeping the original order. All fonts but Zed have the width before the weight and it never turned up [how] Handle widths and weights on their own and only afterwards concattenate width (first) to weights (second). Signed-off-by: Fini Jastrow <[email protected]>
Description
Added a new font: "Zed Mono"
Requirements / Checklist
What does this Pull Request (PR) do?
Adds a new font
How should this be manually tested?
Any background context you can provide?
https://zed.dev/
zed-industries/zed-fonts#10
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)