Update codicons to 0.0.35 #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to 0.0.35 Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
|
Scaled for
|
See PR #1544 Signed-off-by: Fini Jastrow <[email protected]>
|
Two of the 4 icons showing a book have a zero width opening, that we remove manually.
|
With tool, call: fontforge generate-glyph-info-from-set.py --font ../../src/glyphs/codicons/codicon.ttf --start ea60 --end ec1e --offset 0 --prefix cod > i_cod.sh_part Signed-off-by: Fini Jastrow <[email protected]>
|
WAT? 🤔
|
[why] Two glyphs may not have the same name (normally). Our glyphnames.json will break. [how] Do not add two entries with the same name but rather report the codepoints in the bottom. Signed-off-by: Fini Jastrow <[email protected]>
|
Now it's in there 2 times??!
Ah, fixed the script. |
[why] We need the glyphnames to be unique, or some glyphs will not be accessible later (in the cheat sheet, css, glyphnames). [note] Also already remove one non-effective duplicate that is first an alias and later a real glyph in i_seti.sh Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codicons to 0.0.35
https://github.com/microsoft/vscode-codicons/releases
left: our current, right: 0.0.35, modified glyphs marked with blue bar
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)