-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Inconsolata to v3.000 #775
Conversation
This does not include all the new widths and weights. It also does not touch the very old |
Now that the github action is rebuilding the fonts on merging to |
In my opinion this is an excellent change, as with this we exactly know that the patched font in the repo is the same as we would create, and not some user patched it with an older One small drawback is that you can not immediately see the patch results. One possible solution would be this:
For this to work we need to find out which font files are changed and which are already up-to-date in the repo. This might be tricky, but doable. |
This reverts commit 85d4783. [why] The patched fonts will be re-created by the git workflow anyhow and just make rebasing harder. [note] Because the actual font NAMES change, this is not just an update of files, but obsolete files need to be removed. I'm not sure the workflow manages to do that. This has to be checked! Example: old: patched-fonts/CascadiaCode/Bold/complete/Caskaydia Cove Bold Nerd Font Complete.otf new: patched-fonts/CascadiaCode/Bold/complete/Caskaydia Cove Nerd Font Complete Bold.otf FontParser generates the name like this: BasicFontname "Nerd Font" PatchSpecifyer Weight Before FontParser the unpatched name has been taken and just all the stuff added to the end, resulting in this: BasicFontname Weight "Nerd Font" PatchSpecifyer Which is not 'the standard way' to name a font. [note] #775 (comment)
https://github.com/googlefonts/Inconsolata Only small changes visually, but of course completely different from the paths (because now the source is a 2D variable font). Small letter t changed a bit. Under the letter dot and block-building glyphs changed. Subscript numerals. Closes: #774 Signed-off-by: Fini Jastrow <[email protected]>
178f7a8
to
696c0ed
Compare
Remove patch-artifacts, rebase on master, force push. |
Description
Update Inconsolata to current release v3.000.
https://github.com/googlefonts/Inconsolata
Only small changes visually, but of course completely different from the
paths (because now the source is a 2D variable font).
Small letter t changed a bit.
Under the letter dot and block-building glyphs changed.
Subscript numerals.
Requirements / Checklist
What does this Pull Request (PR) do?
Update source font files.
Update generated files.
How should this be manually tested?
Any background context you can provide?
Discussion #774
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)