-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: improper positioning in Safari et al.
In several browsers, getBoundingClientRect returns an object that does not have x/y properties (see https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect). As of 0.1.1, passing the result of getBoundingClientRect to the constructor would cause a type error. Since it's very easy to extend the return value to have those properties, we now do that in our constructor, and update our constructor's typings to accept ClientRect instead of DOMRect.
- Loading branch information
Showing
3 changed files
with
41 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters