Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to include elixir 1.10 to 1.13 and OTP 22 to 24 #28

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

warmwaffles
Copy link
Contributor

This also separates the linting from the testing phase of the workflows to ensure that we only care about the latest linter rules and try to ensure as much backwards compatibility as possible.

@warmwaffles
Copy link
Contributor Author

Here's the example of how the workflow runs https://github.com/warmwaffles/file_store/actions/runs/1743495054

Copy link
Owner

@rzane rzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than that one thing!

Did you, by chance, attempt to run the tests against Windows? It'd be nice if it just worked, but I haven't made any deliberate attempt to support Windows as of yet.

.github/workflows/build.yml Outdated Show resolved Hide resolved
- run: mix deps.get
- run: mix deps.compile
- run: mix format --check-formatted
- run: mix deps.unlock --check-unused
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, I like this one 👍

We want to test against multiple versions of OTP and elixir to ensure as
much backwards compatibility as we can stand.
@rzane rzane merged commit 6f60ec4 into rzane:master Jan 25, 2022
@warmwaffles warmwaffles deleted the update-workflow branch January 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants