perform exception handling outside Parser.parse method

[brbog]

-> allows more consistent use of config.isHaltOnError() (by default everything is logged, but overriding that behavior is easier now)
considering all checked and unchecked exceptions as parsing exceptions (was the de facto behavior)

[brbog]

Removed the (new) method:
protected void onContentFetchError(Page page) {
in favor of the previously deprecated:
protected void onContentFetchError(WebURL webUrl) {
because a page object is not always available and only filled in part when entering this method.

Went all the way for the newer method:
protected void onParseError(WebURL webUrl, Exception e) {
(removed the deprecated one without Exception argument)
because it's very interesting to be able to log the stacktrace of a parsing exception.

[brbog]

I'll fix the build errors later today, but you can have a look already and give feedback if you want.

It started out after seeing possible non consequent exception handling inside the Parser where the config.isHaltOnError() is used for binary content, but nowhere else. There were multiple try catches everywhere which made things less readable. I also broke up some logic inside a couple of methods for readability.

[brbog]

Should be ok now, the most breaking changes are the "onError"-methods mentioned and the parse method that throws Exception instead of ParseException.

The reason I went for updating the exception handling is that I found a bug with the css parser when parsing some css code with the latest constructs, and I would like that the css file is still processed even if parsing it for outgoing urls fails. At the moment we're not there yet as I kept the behavior as it used to be (even if it looks a little different). Changing how we deal with parse errors inside css files together with fixing this inside ph-css should move things forward.

[rzo1]

Thanks for the PR. See my comments :)

[rzo1]

Thanks for the explanations, @brbog !

[brbog]

Variable processed is final now.
Added protected void onContentFetchError(WebURL webUrl, Exception e) and set the previous 2 methods deprecated (having the Exception could be important as the method is called after a multi-catch).