Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some typos #31

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Fixed some typos #31

merged 2 commits into from
Mar 9, 2024

Conversation

mkatychev
Copy link
Contributor

Ran a scan using typos

s-arash
s-arash approved these changes Mar 9, 2024
View reviewed changes
Copy link
Owner

@s-arash s-arash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mkatychev
Copy link
Contributor Author

@s-arash I had to bump the minimum rustc version due to this message: https://github.com/s-arash/ascent/actions/runs/8208559212/job/22470615111?pr=31#step:13:12

@s-arash
Copy link
Owner

s-arash commented Mar 9, 2024

@mkatychev I fixed the CI error (#33).
If you undo your second commit and rebase your PR on master, the CI issue will be gone.

@mkatychev
Copy link
Contributor Author

mkatychev commented Mar 9, 2024 •
edited
Loading

@mkatychev I fixed the CI error (#33). If you undo your second commit and rebase your PR on master, the CI issue will be gone.

done

@s-arash could you link https://s-arash.github.io/ascent/ in the About section of the GH repo? That would really help make syntax discovery simpler.

@s-arash s-arash merged commit 6229a82 into s-arash:master Mar 9, 2024
2 checks passed
@s-arash
Copy link
Owner

s-arash commented Mar 9, 2024

@mkatychev The github.io page is currently just an older version of README.MD

@mkatychev
Copy link
Contributor Author

you are correct, my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-arash s-arash s-arash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkatychev @s-arash