This repository has been archived by the owner on Dec 1, 2019. It is now read-only.
Remove file extensions while resolving dependencies. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of microsoft/TypeScript#9646, TypeScript no longer expects extensions in dependency resolution functions.
|
I'm not sure if this is the best way of fixing this -- having TypeScript try all possible extensions when we know the correct one seems hacky. This change should not remove compatibility with TS 2.0.0, as TS 2.0.0 optionally accepted extensionless imports. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of microsoft/TypeScript#9646, TypeScript no longer expects extensions
in dependency resolution functions.
This should fix #221.