Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use thumbnails on the home screen #1054

Merged
merged 8 commits into from
Dec 17, 2023
Merged

perf: use thumbnails on the home screen #1054

merged 8 commits into from
Dec 17, 2023

Conversation

adil192
Copy link
Member

@adil192 adil192 commented Dec 13, 2023

Tasks

  • Take screenshots
  • Display screenshots and invert them if needed
  • Fix the "_elements.contains(element)" Flutter assertion
  • Don't display screenshots as separate files in recent notes/browse pages
  • Fallback to old method if thumbnail file doesn't exist

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (946602c) 36.10% compared to head (110e18f) 36.45%.

Files Patch % Lines
lib/components/home/preview_card.dart 0.00% 55 Missing ⚠️
lib/components/canvas/canvas_preview.dart 0.00% 14 Missing ⚠️
lib/pages/editor/editor.dart 76.08% 11 Missing ⚠️
lib/data/editor/page.dart 73.33% 4 Missing ⚠️
lib/components/settings/nextcloud_profile.dart 0.00% 2 Missing ⚠️
lib/data/file_manager/file_manager.dart 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   36.10%   36.45%   +0.35%     
==========================================
  Files         107      107              
  Lines        8347     8360      +13     
==========================================
+ Hits         3014     3048      +34     
+ Misses       5333     5312      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adil192 adil192 added the enhancement New feature or request label Dec 17, 2023
@adil192 adil192 merged commit b08f0e3 into main Dec 17, 2023
2 checks passed
@adil192 adil192 deleted the thumbnails branch December 17, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant