fix: remote files are not synced #1314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #1304 also |
|
Thanks for finding this! I've not been able to for ages. |
adil192
reviewed
Jul 20, 2024
| // Local file is newer, do nothing | ||
| break; | ||
| case BestFile.remote: | ||
| case BestFile.either: //local file does not exists |
There was a problem hiding this comment.
Why did you change this part? BestFile.either should be when the local and remote files are equivalent, so no sync needs to occur for this file
There was a problem hiding this comment.
BestFile.either is also returned when local file does not exist. I did not searched the code why.
There was a problem hiding this comment.
Thanks, I've improved this aspect in 01b28d9
adil192
added a commit
that referenced
this pull request
Jul 20, 2024
* test: ensure files are decrypted correctly * fix: relativeLocalPath shouldn't start with documents dir A huge thank you to @QubaB for their work finding the problem in #1314 This commit fixes the problem slightly earlier in the syncing process, and adds a test for it Closes #1306, Closes #1304, Closes #1314
adil192
added a commit
that referenced
this pull request
Jul 20, 2024
* test: ensure files are decrypted correctly * fix: relativeLocalPath shouldn't start with documents dir A huge thank you to @QubaB for their work finding the problem in #1314 This commit fixes the problem slightly earlier in the syncing process, and adds a test for it Closes #1306, Closes #1304, Closes #1314 Co-Authored-By: QubaB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix problems with syncing notes from nextcloud server
closes #1306