Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: polish wording in NatSpec #1014

Merged
merged 2 commits into from
Aug 14, 2024
Merged

docs: polish wording in NatSpec #1014

merged 2 commits into from
Aug 14, 2024

Conversation

PaulRBerg
Copy link
Member

No description provided.

@PaulRBerg
Copy link
Member Author

Lint job is failing, but it's because of the recent Foundry Formatter update.

I will let you @sablier-labs/solidity decide if you want to perform the changes directly to staging or onto another branch.

@andreivladbrg
Copy link
Member

Lint job is failing, but it's because of the recent Foundry Formatter update.

I will let you @sablier-labs/solidity decide if you want to perform the changes directly to staging or onto another branch.

the formatting problem it's been addressed in #1011, after we merge that PR to staging we will rebase in this one

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the polished version.

src/core/types/DataTypes.sol Outdated Show resolved Hide resolved
src/core/types/DataTypes.sol Outdated Show resolved Hide resolved
src/core/types/DataTypes.sol Outdated Show resolved Hide resolved
@PaulRBerg
Copy link
Member Author

Thanks for the review. Fixed the issues.

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-22 at 3 18 14 PM

@andreivladbrg
Copy link
Member

Will merge it first, since it is a small PR and it causes no conflicts in the claim dry fy.

@andreivladbrg andreivladbrg merged commit cb43e66 into staging Aug 14, 2024
6 of 7 checks passed
@smol-ninja smol-ninja deleted the docs/nitpicks branch August 14, 2024 13:18
andreivladbrg pushed a commit that referenced this pull request Sep 11, 2024
* docs: polish wording in NatSpec

* docs: fixes
andreivladbrg pushed a commit that referenced this pull request Oct 8, 2024
* docs: polish wording in NatSpec

* docs: fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants