Support multiget addressdata filter #1310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 4918, there is two types of response elements: Type 1 contains one or more href and one status child elements. Type 2 contains one href and one or more propstat child elements. Both types may contain further optional elements. For Type 1, sabre/dav inserts a spurious propstat element, which violated the element definition by RFC 4918.
Analog to addressbook-query report, multiget also supports returning only partial address objects. This can be useful to carddav clients to have fast syncs by excluding large properties like PHOTO and fetching those only when needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
============================================
- Coverage 97.14% 97.11% -0.03%
Complexity 2793 2793
============================================
Files 174 174
Lines 8119 8121 +2
============================================
Hits 7887 7887
- Misses 232 234 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support filtering returned address object properties in multiget report
Analog to addressbook-query report, multiget also supports returning only partial address objects. This can be useful to carddav clients to have fast syncs by excluding large properties like PHOTO and fetching those only when needed.