DAV\PropPatch::handleRemaining should only register one callback #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
=========================================
Coverage 97.24% 97.24%
Complexity 2834 2834
=========================================
Files 175 175
Lines 8843 8843
=========================================
Hits 8599 8599
Misses 244 244 ☔ View full report in Codecov by Sentry. |
DeepDiver1975
requested changes
Sep 5, 2024
paulmhh
force-pushed
the
master
branch
2 times, most recently
from
df9f086
to
842df42
Compare
|
sorry for the force pushes, had some trouble to run the github workflow and then the cs-fixer wanted some minor change and I had to iterate. I did test the test without my fix. It fails. With the fix applied it is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently handleRemaining() will create one callback for each remaining property update but with the whole array of remaining properties as parameter. Thus doCallBackMultiProp() is being used (in each callback! It should be either one callback with an array as parameter, or it should multiple callbacks with a string as parameter)