RunAll task for running on multiple networks #716
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 87.41% 91.30% +3.89%
==========================================
Files 43 43
Lines 2066 2071 +5
Branches 350 438 +88
==========================================
+ Hits 1806 1891 +85
+ Misses 260 180 -80
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
penandlim
suggested changes
Sep 14, 2022
tasks/runAll.ts
Outdated
Comment on lines
21
to
22
| console.log(`script failed on ${key} network with: `) | ||
| console.log(e) |
There was a problem hiding this comment.
Should this be console.error?
penandlim
reviewed
Sep 14, 2022
scripts/poolSummary.ts
Outdated
Comment on lines
23
to
40
| // const poolRegistry = (await ethers.getContract( | ||
| // "PoolRegistry", | ||
| // )) as PoolRegistry | ||
|
|
||
| // const sdl = (await ethers.getContract("SDL")) as SDL | ||
| // const veSDL = (await ethers.getContract("VotingEscrow")) as VotingEscrow | ||
| // const minter = (await ethers.getContract("Minter")) as Minter | ||
| // const feeDistributor = (await ethers.getContract( | ||
| // "FeeDistributor", | ||
| // )) as FeeDistributor | ||
|
|
||
| // // get all pools from pool registry | ||
| // let poolRegLegnth: number = (await poolRegistry.getPoolsLength()).toNumber() | ||
| // const lastpool = await poolRegistry.getPoolDataAtIndex(poolRegLegnth - 1) | ||
| // console.log(lastpool) | ||
| // const DAY = 86400 | ||
| // const WEEK = 86400 * 7 | ||
| // const YEAR = WEEK * 52 |
There was a problem hiding this comment.
Please remove the comments if they are unnecessary to run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.