WIP meta pool contracts with gauge token support #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
===========================================
- Coverage 92.88% 77.64% -15.24%
===========================================
Files 52 56 +4
Lines 3052 3651 +599
Branches 634 595 -39
===========================================
Hits 2835 2835
- Misses 217 816 +599
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
penandlim
force-pushed
the
john/metaSwapWithGaugeSupport
branch
from
8ade918
to
fdcc658
Compare
|
|
||
| // Check the last element of _pooledTokens is a gauge token | ||
| // This is a naiive check | ||
| IERC20 guageToken = _pooledTokens[_pooledTokens.length - 1]; |
There was a problem hiding this comment.
Nit: "gauge" misspelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 4 new contracts
Meta* contracts are cloned from existing metaswap contracts with modifications to support depositing/withdrawing from gauges. MetaSwapGaugeSupportV1 has a new inheritence from GaugeTokenHolder.