Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base_testnet Goerli deployment #800

Merged
merged 22 commits into from
Apr 7, 2023
Merged

Conversation

lilPlumberBoy
Copy link
Contributor

@lilPlumberBoy lilPlumberBoy commented Mar 6, 2023

Deployments:
url: https://goerli.base.org/
chainId: 84531
explorer: https://goerli.basescan.org
Official Multicall deployment: 0xcA11bde05977b3631167028862bE2a173976CA11

Was only able to verify Swap using the following line:
npx hardhat verify --contract contracts/SwapV2.sol:SwapV2 --network base_testnet "0x47a303F4278AE7F970624C980A036868c5267AAa"

All other contracts verified through deploy script etherscan-verify

@lilPlumberBoy lilPlumberBoy requested a review from a team March 6, 2023 15:59
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #800 (e6ee0ec) into master (bdd0be5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          52       52           
  Lines        3065     3065           
  Branches      512      512           
=======================================
  Hits         2835     2835           
  Misses        230      230           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilPlumberBoy lilPlumberBoy marked this pull request as ready for review March 6, 2023 16:38
@penandlim
Copy link
Contributor

Will leave this unapproved until the contracts are verified

hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Show resolved Hide resolved
Copy link
Contributor

@penandlim penandlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better location for dummy erc20s is contracts/helper/ which is excluded from coverage.

@lilPlumberBoy lilPlumberBoy merged commit d2c01c3 into master Apr 7, 2023
@lilPlumberBoy lilPlumberBoy deleted the mike/baseGoerliDeployment branch April 7, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants