Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients chart color fix #1432

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Clients chart color fix #1432

merged 1 commit into from
Jul 28, 2023

Conversation

Shruti-Apte
Copy link
Contributor

@Shruti-Apte Shruti-Apte commented Jul 27, 2023 •
edited
Loading

Notion :

4th point in this ticket

What :

  • Multiple clients were showing the same color simultaneously or alternatively.
  • Filtered data array: removed the elements with 0 minutes values.
  • Round up the percentage to ceil value if it is less than 1.

Why :

  • Because few clients have less logged hours/minutes data, such as 2 minutes or even 0 minutes. So these values were coming very small (e.g 0.02 %) after converting it to the hour percentage on a chart and that's why it was being neglected.

Preview :

Before:
Screenshot 2023-07-27 at 3 18 20 PM

After:
Screenshot 2023-07-27 at 3 18 41 PM

@apoorv1316 apoorv1316 merged commit a30c89c into develop Jul 28, 2023
@apoorv1316 apoorv1316 deleted the multiple_clients_have_same_color branch July 28, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees

@apoorv1316 apoorv1316

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shruti-Apte @apoorv1316