Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View holidays calendar #1488

Merged
merged 15 commits into from
Oct 20, 2023
Merged

View holidays calendar #1488

merged 15 commits into from
Oct 20, 2023

Conversation

prasanthchaduvula
Copy link
Contributor

@prasanthchaduvula prasanthchaduvula commented Sep 28, 2023 •
edited
Loading

What

  • View national holidays and optional holidays on the calendar
  • Fixed the date picker edit bug on the edit holidays page
  • Fixed the date format on the holiday module to align with organization level date format

Demo

https://www.youtube.com/watch?v=uUp0Bu9VBv8

@prasanthchaduvula prasanthchaduvula marked this pull request as ready for review September 29, 2023 07:52
@prasanthchaduvula prasanthchaduvula requested review from apoorv1316 and removed request for gowsik-ragunath October 5, 2023 04:55
@apoorv1316
Copy link
Contributor

@prasanthchaduvula Please work on the changes discussed in the call.

@prasanthchaduvula prasanthchaduvula removed the request for review from apoorv1316 October 9, 2023 06:05
@akhilgkrishnan akhilgkrishnan added this to the 1.1.0 milestone Oct 11, 2023
@apoorv1316
Copy link
Contributor

@prasanthchaduvula Please fix the bugs related to date format, calendar view, and year list as we discussed in the call.

apoorv1316
apoorv1316 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasanthchaduvula Please remove the cursor pointer and background color on hover on the calendar
Screenshot 2023-10-20 at 12 05 43 PM

@prasanthchaduvula
Copy link
Contributor Author

@apoorv1316 If we remove the background colour and cursor pointer on hover then user wont receive the feedback

@prasanthchaduvula prasanthchaduvula merged commit 021ecb5 into develop Oct 20, 2023
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the holidays-calendar-view branch October 20, 2023 08:20
@apoorv1316
Copy link
Contributor

@prasanthchaduvula Nothing happens when we click on the calendar date. It's there just for viewing the holidays.
Are we going to add any functionality to it in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees

@prasanthchaduvula prasanthchaduvula

Labels
hacktoberfest
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prasanthchaduvula @apoorv1316 @akhilgkrishnan @gowsik-ragunath