-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/added loader to all pages #1535
Fix/added loader to all pages #1535
Conversation
Hey @prasanthchaduvula I have raised the PR for the issue #1494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rayy40 for working on this 👍 .
If possible could you please record a demo video for the output.
…dd customization option
…yy40/miru-web into fix/Added-Loader-to-all-pages
@akhilgkrishnan , I have updated the changes. |
@apoorv1316 Could you please test this PR? |
@apoorv1316 Have you tested this PR ? |
@prasanthchaduvula We have an empty state for reports and a few other pages that appear while the page is loaded and in this PR we are using the 'Miru Loader' on almost all pages. It's not consistent. Let's try to make it more consistent across the app. |
If possible can you list all the pages? |
@apoorv1316 @akhilgkrishnan , Hey guys any updates? |
@apoorv1316 We can create a separate ticket adding the loader for missing pages. Could you please check the current implementation, if everything looks good we can merge. |
Fixes
Use common loader across all the pages of the application
Reference - #1494
Solution
For the pages that lacked a loading state, the loading state was created, and a 'Loader' was added to display the loading.
Additionally, the pages that were already in a loading state were changed to use the proper 'Loader' style.