Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/added loader to all pages #1535

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Fix/added loader to all pages #1535

merged 6 commits into from
Oct 12, 2023

Conversation

rayy40
Copy link
Contributor

@rayy40 rayy40 commented Oct 7, 2023

Fixes

Use common loader across all the pages of the application
Reference - #1494

Solution

For the pages that lacked a loading state, the loading state was created, and a 'Loader' was added to display the loading.
Additionally, the pages that were already in a loading state were changed to use the proper 'Loader' style.

import Loader from "common/Loader/index"

<div className="flex h-full w-full items-center justify-center">
      <Loader />
</div>

@rayy40
Copy link
Contributor Author

rayy40 commented Oct 7, 2023

Hey @prasanthchaduvula I have raised the PR for the issue #1494
Can you please review it and let me know if I should make any changes?

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rayy40 for working on this 👍 .
If possible could you please record a demo video for the output.

@rayy40
Copy link
Contributor Author

rayy40 commented Oct 9, 2023

@akhilgkrishnan , I have updated the changes.
Can you please take a look at it?

@akhilgkrishnan
Copy link
Member

@apoorv1316 Could you please test this PR?

@supriya3105
Copy link
Contributor

@apoorv1316 Have you tested this PR ?

@apoorv1316
Copy link
Contributor

@prasanthchaduvula We have an empty state for reports and a few other pages that appear while the page is loaded and in this PR we are using the 'Miru Loader' on almost all pages. It's not consistent. Let's try to make it more consistent across the app.

@akhilgkrishnan
Copy link
Member

@prasanthchaduvula We have an empty state for reports and a few other pages that appear while the page is loaded and in this PR we are using the 'Miru Loader' on almost all pages. It's not consistent. Let's try to make it more consistent across the app.

If possible can you list all the pages?

@rayy40
Copy link
Contributor Author

rayy40 commented Oct 11, 2023

@apoorv1316 @akhilgkrishnan , Hey guys any updates?

@akhilgkrishnan
Copy link
Member

@apoorv1316 @akhilgkrishnan , Hey guys any updates?

@apoorv1316 We can create a separate ticket adding the loader for missing pages. Could you please check the current implementation, if everything looks good we can merge.

@apoorv1316 apoorv1316 merged commit f50960a into saeloun:develop Oct 12, 2023
1 check passed
@rayy40 rayy40 deleted the fix/Added-Loader-to-all-pages branch October 13, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants