Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed settings routing #1542

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Fixed settings routing #1542

merged 4 commits into from
Oct 18, 2023

Conversation

prasanthchaduvula
Copy link
Contributor

What

  • Namespaced settings routing. Now they are resourceful naming-wise.
  • Added roles to the routes to make sure who can access what route
  • Refactored the settings codebase to add and update routes easily
  • Implemented these changes for both web and mobile

Demo

https://youtu.be/aVfJ-GPz4r8?feature=shared

@reettikgoswami reettikgoswami mentioned this pull request Oct 17, 2023
Closed
3 tasks
@prasanthchaduvula prasanthchaduvula merged commit 7a571cf into develop Oct 18, 2023
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the fix-settings-routes branch October 18, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees

@prasanthchaduvula prasanthchaduvula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasanthchaduvula @apoorv1316