Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed project hours #1562

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fixed project hours #1562

merged 4 commits into from
Oct 31, 2023

Conversation

prasanthchaduvula
Copy link
Contributor

  • Refactored the Projects::IndexService
  • Used the same service for project search as well.
  • Updated specs accordingly.
  • Need to remove Projects::SerachService when ever we implement the projects filter and move the codebase to Projects::IndexService

@supriya3105
Copy link
Contributor

@prasanthchaduvula Please fix the tests and reassign to Gowsik for review

gowsik-ragunath
gowsik-ragunath approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prasanthchaduvula prasanthchaduvula merged commit e640972 into develop Oct 31, 2023
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the fix-project-hours branch October 31, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowsik-ragunath gowsik-ragunath gowsik-ragunath approved these changes

Assignees

@gowsik-ragunath gowsik-ragunath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasanthchaduvula @supriya3105 @gowsik-ragunath