Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mails styling invite #1654

Merged
merged 17 commits into from
Mar 26, 2024
Merged

Mails styling invite #1654

merged 17 commits into from
Mar 26, 2024

Conversation

adititipnis
Copy link
Contributor

image

@apoorv1316
Copy link
Contributor

@adititipnis This is how it is looking in my local. Please check and also check failing specs
Screenshot 2024-01-22 at 3 17 25 PM

@apoorv1316
Copy link
Contributor

@adititipnis Can you please work on it?

<div class="mail invitation">
<img class="background" src=<%= Rails.root.join('public', 'Background.svg') %> alt="background">
<img class="banner" src=<%= Rails.root.join('public', 'Banner.svg') %> alt="banner">
<p class="header">You have been invited to Miru</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved these to assets/images because the public folder is not available to build. Also, use it like this

<%= image_tag "Background.svg", class: "background" %>

</ul>
<div class='sender_company_container'> 
<div class='sender'>
<img src=<%= @sender_details&.[](:avatar) ? @sender_details&.[](:avatar) : Rails.root.join('public', 'avatar.svg') %> alt="User avatar" height="40px" width="40px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto. check if image is in assets/images if not then move it and use the <%= image_tag %>

<%= @sender_details&.[](:email) %>
</div>
<div class='company'>
<img src=<%=@company_details&.[](:logo) ?@company_details&.[](:logo) : Rails.root.join('public', 'miru-logo.svg') %> alt="User avatar" height="40px" width="40px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

<div class="about-miru-container">
<div class="about-miru">
<img class="about-miru-background" src=<%= Rails.root.join('public', 'about-miru-background.svg') %> alt="about-miru-background">
<img class="miru-logo" src=<%= Rails.root.join('public', 'miru-logo.svg') %> alt="miru-logo">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@apoorv1316 apoorv1316 merged commit 7fd54bb into develop Mar 26, 2024
1 check passed
@apoorv1316 apoorv1316 deleted the mails-styling-invite branch March 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants