Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enable / disable of optional holidays #1740

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Fix enable / disable of optional holidays #1740

merged 2 commits into from
Mar 21, 2024

Conversation

nisusam
Copy link
Contributor

@nisusam nisusam commented Mar 20, 2024

Fix enable / disable of optional holidays
bc783d3 
- Show only `National` holidays in dropdown after diabling `Optional` holiday
- Remove unwanted validation and respective spec
@nisusam nisusam marked this pull request as draft March 20, 2024 17:12
@nisusam nisusam marked this pull request as ready for review March 20, 2024 17:36
@prasanthchaduvula prasanthchaduvula merged commit 64f6723 into develop Mar 21, 2024
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the optional_holidays_settings_fix branch March 21, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasanthchaduvula prasanthchaduvula prasanthchaduvula approved these changes

@SiddharthShringi SiddharthShringi Awaiting requested review from SiddharthShringi

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin should be able to disable optional holidays under holidays tab in settings
2 participants
@nisusam @prasanthchaduvula