Skip to content

Commit

Permalink
Rollup merge of #106921 - madsmtm:cell-memory-layout, r=dtolnay
Browse files Browse the repository at this point in the history
Add documentation about the memory layout of `Cell`

rust-lang/rust#101717 guaranteed the memory layout of `UnsafeCell<T>`.

This property (a guaranteed memory layout) can be useful to have on `Cell<T>` as well.

(Note that `Cell<u8>` [already doesn't trigger the `improper_ctypes` lint](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=34af59ef60b96d8a8bdaec1d52cb5420) since it is `#[repr(transparent)]`).

The concrete use-case is for the crate [`objc2`](https://github.com/madsmtm/objc2) to specify that `Cell<T>` is safe to use as an instance variable when `T` is.

Fixes rust-lang/rust#79303.

---

I'm unsure if we should specify less, for example say that the `Cell` may have extra restrictions on when it may be accessed, or if that's implicit in the (deliberately minimal) way I've worded it here?
  • Loading branch information
matthiaskrgr authored Mar 10, 2023
2 parents ec2846e + 0b98ef9 commit 2e6e886
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 2e6e886

Please sign in to comment.