Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure and run pre-commit #699

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Configure and run pre-commit #699

wants to merge 12 commits into from

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 4, 2022

@Uxio0 Uxio0 requested a review from a team as a code owner November 4, 2022 11:15
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing many changes and I believe more context is needed

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3395314213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.772%

Totals Coverage Status
Change from base Build 3395265201: 0.0%
Covered Lines: 876
Relevant Lines: 878

💛 - Coveralls

@Uxio0
Copy link
Member Author

Uxio0 commented May 30, 2024

@hectorgomezv do you think this is relevant nowadays or should I close it? I still feel that all the Safe projects should have the same linting/style

@hectorgomezv hectorgomezv requested a review from a team as a code owner August 23, 2024 11:23
@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 11443027844

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.501%

Totals Coverage Status
Change from base Build 11442640726: 0.0%
Covered Lines: 1197
Relevant Lines: 1203

💛 - Coveralls

@hectorgomezv
Copy link
Member

@hectorgomezv do you think this is relevant nowadays or should I close it? I still feel that all the Safe projects should have the same linting/style

Sorry @Uxio0, I completely missed this comment. I've fixed some conflicts on the PR. If you are OK with the changes I think we can merge.

@hectorgomezv hectorgomezv requested review from fmrsabino and removed request for fmrsabino October 16, 2024 11:34
@hectorgomezv
Copy link
Member

@Uxio0 we did some amendments (branch rebasing mostly) to the PR, if you are OK with the current status we will merge it finally 🙂

run: flake8
strategy:
matrix:
python-version: ["3.12.2"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this as 3.12 so hotfixes are auto updated

Copy link
Member Author

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, but everything else looks good!

@hectorgomezv
Copy link
Member

Just a minor comment, but everything else looks good!

Thanks! Done in 2b6a52b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants