-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure and run pre-commit #699
base: main
Are you sure you want to change the base?
Conversation
Uxio0
commented
Nov 4, 2022
•
edited
Loading
edited
- Related to Refactor the project structure to follow the same from other Safe projects #517
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is doing many changes and I believe more context is needed
9acf10f
to
aae83c7
Compare
aae83c7
to
b27490e
Compare
Pull Request Test Coverage Report for Build 3395314213
💛 - Coveralls |
@hectorgomezv do you think this is relevant nowadays or should I close it? I still feel that all the Safe projects should have the same linting/style |
Pull Request Test Coverage Report for Build 11443027844Details
💛 - Coveralls |
Sorry @Uxio0, I completely missed this comment. I've fixed some conflicts on the PR. If you are OK with the changes I think we can merge. |
@Uxio0 we did some amendments (branch rebasing mostly) to the PR, if you are OK with the current status we will merge it finally 🙂 |
.github/workflows/test.yml
Outdated
run: flake8 | ||
strategy: | ||
matrix: | ||
python-version: ["3.12.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this as 3.12
so hotfixes are auto updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment, but everything else looks good!
Thanks! Done in 2b6a52b |