Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add features to safe apps #756

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Feature: add features to safe apps #756

merged 1 commit into from
Jan 16, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 13, 2023

This PR:

@mmv08 mmv08 requested a review from a team as a code owner January 13, 2023 09:32
@mmv08 mmv08 requested review from fmrsabino, Uxio0 and moisses89 and removed request for a team January 13, 2023 09:32
@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mmv08
Copy link
Member Author

mmv08 commented Jan 13, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 13, 2023
@github-actions
@mikhailxyz has signed the CLA from Pull Request #756
7d4c795
@coveralls
Copy link

coveralls commented Jan 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3931203970

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.777%
Totals Coverage Status
Change from base Build 3931113461: 0.005%
Covered Lines: 894
Relevant Lines: 896
💛 - Coveralls

fmrsabino
fmrsabino previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

src/safe_apps/migrations/0009_safe_apps_features.py Outdated Show resolved Hide resolved
src/safe_apps/serializers.py Show resolved Hide resolved
@mmv08 mmv08 force-pushed the feature/store-safe-app-features branch from aeb41ae to 68c1eec Compare January 16, 2023 14:11
@mmv08 mmv08 requested a review from fmrsabino January 16, 2023 14:20
fmrsabino
fmrsabino approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@mmv08 mmv08 merged commit 814b8eb into main Jan 16, 2023
@mmv08 mmv08 deleted the feature/store-safe-app-features branch January 16, 2023 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @fmrsabino