-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-kit): Predict Safe address improvements #982
Merged
yagopv
merged 31 commits into
development
from
feat/predict-safe-address-custom-contracts
Sep 26, 2024
Merged
feat(protocol-kit): Predict Safe address improvements #982
yagopv
merged 31 commits into
development
from
feat/predict-safe-address-custom-contracts
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-sdk into feat/predict-safe-address-custom-contracts
Pull Request Test Coverage Report for Build 11052216509Details
💛 - Coveralls |
…e-sdk into feat/predict-safe-address-custom-contracts # Conflicts: # packages/protocol-kit/src/Safe.ts # packages/protocol-kit/src/SafeProvider.ts
dasanra
reviewed
Sep 26, 2024
dasanra
reviewed
Sep 26, 2024
dasanra
approved these changes
Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #968
How this PR fixes it
it returns the following:
We can check the specific safe version and deployment type of a Safe contract Ethereum address
SafeDeploymentConfig
When using this new property with the
predictedSafe
, the protocolKit initialisation step will use the specified deployment typeSafeProvider.init
method params to an options object