Make type_eq_non_static more robust
#11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By returning and checking equality of function name of `TypeIdNonStatic::of` and the type name of `T`. This would makes it even more unlikely for LLVM to merge these functions and prevent false positive. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
force-pushed
the
improve-robustness
branch
from
3fe604d
to
09cb422
Compare
|
CI "1.38.0 macos-latest" fail when compiling |
|
The CI failure is probably caused by rust-lang/rust#107252 |
|
Sorry for my long absence here. Closing this in favor of #14 which avoids function pointers entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By returning and checking equality of function name of
TypeIdNonStatic::of, the type name ofTand theneeds_dropattribute ofT.This would makes it even more unlikely for LLVM to merge these functions and prevent false positive.
Signed-off-by: Jiahao XU [email protected]