Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml, remove Cython from setup_requires, install_requires #177

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Sep 18, 2023

Fixes #171.

For now, we use "Cython < 3".
Fixes for Cython 3 in separate PRs.

@mkoeppe
Copy link
Author

mkoeppe commented Sep 18, 2023

@dimpase This fixes the wheel build. Please review & merge -- as a first step.

@malb
Copy link
Member

malb commented Sep 21, 2023

From the GitHub Actions it seems the change doesn't take, they still use Cython 3.0?

@dimpase
Copy link
Member

dimpase commented Sep 21, 2023

GH actions are just badly broken here

@malb
Copy link
Member

malb commented Sep 21, 2023

LGTM, if we ignore GH I think we can merge this one

@dimpase
Copy link
Member

dimpase commented Sep 21, 2023

let me test how it plays with Sage

@dimpase dimpase merged commit 4b4d54a into sagemath:main Sep 21, 2023
7 of 20 checks passed
@dimpase
Copy link
Member

dimpase commented Sep 21, 2023

OK!

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Cython from install-requires
3 participants