Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

ReleaseApplication.merge: Actually handle merge conflicts #56

Closed

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jan 23, 2022

Before:

Loading ticket...
URL: https://trac.sagemath.org/33100
Trac #33100: is_positive_definite returns wrong results
Branch u/mjo/ticket/33100
Author(s): Michael Orlitzky
Reviewer(s): Markus Wageringel
Fetching remote branch...

From git://trac.sagemath.org/sage
 * branch                  u/mjo/ticket/33100 -> FETCH_HEAD

Merging ticket...
Traceback (most recent call last):
  File "/Users/mkoeppe/s/sage/git-trac-command/git-releasemgr", line 16, in <module>
    cmdline.launch()
  File "/Users/mkoeppe/s/sage/git-trac-command/git_trac/releasemgr/cmdline.py", line 167, in launch
    app.merge_all(args.limit, milestone=args.milestone)
  File "/Users/mkoeppe/s/sage/git-trac-command/git_trac/releasemgr/app.py", line 283, in merge_all
    self.merge(ticket_number)
  File "/Users/mkoeppe/s/sage/git-trac-command/git_trac/releasemgr/app.py", line 134, in merge
    self.git.echo.merge('FETCH_HEAD', '--no-ff', '--no-commit')
  File "/Users/mkoeppe/s/sage/git-trac-command/git_trac/git_interface.py", line 340, in meth
    return self.execute(git_cmd, *args, **kwds)
  File "/Users/mkoeppe/s/sage/git-trac-command/git_trac/git_interface.py", line 97, in execute
    popen_stderr=subprocess.PIPE)
  File "/Users/mkoeppe/s/sage/git-trac-command/git_trac/git_interface.py", line 262, in _run
    raise GitError(result)
git_trac.git_error.GitError: git returned with non-zero exit code (1) when executing "git merge FETCH_HEAD --no-ff --no-commit"
    STDOUT: Auto-merging src/sage/matrix/matrix_double_dense.pyx
    STDOUT: CONFLICT (content): Merge conflict in src/sage/matrix/matrix_double_dense.pyx
    STDOUT: Automatic merge failed; fix conflicts and then commit the result.

@vbraun
Copy link
Member

vbraun commented Jan 24, 2022

Did you accidentally open this PR? It seems that the commit is duplicated (instead of referenced) in #57

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 24, 2022

I cherry-picked & will be happy to rebase

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 24, 2022

but I'll close this one as you already started to review #57.

@mkoeppe mkoeppe closed this Jan 24, 2022
@mkoeppe mkoeppe deleted the releasemgr_handle_merge_error branch January 30, 2022 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants