Skip to content

Commit

Permalink
Trac #30745: Allow using arb, flint and ntl from Homebrew
Browse files Browse the repository at this point in the history
- ntl/flint/singular: https://groups.google.com/d/msg/sage-
devel/KXK_zxzfhIQ/0MaSLhvMAAAJ
- ecl: Reported in https://groups.google.com/d/msg/sage-
devel/gFaUNw4v3aw/P-dTJ5IOCgAJ

`/usr/local` is leaking into our build, through wrong orders of include
and/or library directives.

Critical for 9.3 because it affects a major supported platform. We
should at least give a configure-time error if these installations are
found on homebrew if we cannot fix this.

URL: https://trac.sagemath.org/30745
Reported by: mkoeppe
Ticket author(s): Dima Pasechnik
Reviewer(s): John Palmieri
  • Loading branch information
Release Manager committed Nov 24, 2020
2 parents 97c6b93 + 2fd95cd commit 2458f59
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 9 deletions.
4 changes: 1 addition & 3 deletions build/pkgs/arb/distros/homebrew.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
## This package depends on ntl, the homebrew package of which we cannot use
## because it is built with NTL_THREADS. See https://trac.sagemath.org/ticket/29339
# sagemath/science/arb
arb
4 changes: 1 addition & 3 deletions build/pkgs/flint/distros/homebrew.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
## This package depends on ntl, the homebrew package of which we cannot use
## because it is built with NTL_THREADS. See https://trac.sagemath.org/ticket/29339
# sagemath/science/flint
flint
4 changes: 1 addition & 3 deletions build/pkgs/ntl/distros/homebrew.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
## We cannot use ntl on homebrew because it is built with NTL_THREADS.
## See https://trac.sagemath.org/ticket/29339
# ntl
ntl
2 changes: 2 additions & 0 deletions src/sage/rings/polynomial/plural.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ cdef class NCPolynomialRing_plural(Ring):
True
sage: H is loads(dumps(H)) # indirect doctest
True
sage: A2.<x,y,z> = FreeAlgebra(GF(5), 3)
sage: R2 = A2.g_algebra({y*x:x*y-z, z*x:x*z+2*x, z*y:y*z-2*y}, order=TermOrder('degrevlex', 2))
Check that :trac:`17224` is fixed::
Expand Down

0 comments on commit 2458f59

Please sign in to comment.