Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parsing of nodoctest #13062

Closed
roed314 opened this issue May 29, 2012 · 8 comments
Closed

Change parsing of nodoctest #13062

roed314 opened this issue May 29, 2012 · 8 comments

Comments

@roed314
Copy link
Contributor

roed314 commented May 29, 2012

Currently Sage will refrain from doctesting a file if the string "nodoctest" is in the first 50 characters. 50 characters is pretty short, and I think it's also good to encourage people to start the line with nodoctest. So I would propose that we change "somewhere in the first 50 characters" to "one of the first 10 lines starts with '# nodocteset' or '.. nodoctest'".

Depends on #12415
Depends on #14331

Component: doctest framework

Author: David Roe, Jeroen Demeyer

Reviewer: Jeroen Demeyer, David Roe

Merged: sage-5.9.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13062

@roed314
Copy link
Contributor Author

roed314 commented Mar 14, 2013

comment:1

Attachment: 13062.patch.gz

@jdemeyer
Copy link

comment:2

I feel like this solution is overkill. Why not simply replace read(50) by read(512)? That should be enough and would probably be more effecient too.

@jdemeyer
Copy link

Changed dependencies from #12415 to #12415, #14331

@jdemeyer
Copy link

Attachment: 13062_nodoctest_review.patch.gz

@jdemeyer
Copy link

Author: David Roe, Jeroen Demeyer

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer, David Roe

@roed314
Copy link
Contributor Author

roed314 commented Mar 27, 2013

comment:5

Looks fine to me.

@jdemeyer
Copy link

Merged: sage-5.9.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants