-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change parsing of nodoctest #13062
Comments
comment:1
Attachment: 13062.patch.gz |
comment:2
I feel like this solution is overkill. Why not simply replace |
Attachment: 13062_nodoctest_review.patch.gz |
Author: David Roe, Jeroen Demeyer |
Reviewer: Jeroen Demeyer, David Roe |
comment:5
Looks fine to me. |
Merged: sage-5.9.beta2 |
This was referenced Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently Sage will refrain from doctesting a file if the string "nodoctest" is in the first 50 characters. 50 characters is pretty short, and I think it's also good to encourage people to start the line with nodoctest. So I would propose that we change "somewhere in the first 50 characters" to "one of the first 10 lines starts with '# nodocteset' or '.. nodoctest'".
Depends on #12415
Depends on #14331
Component: doctest framework
Author: David Roe, Jeroen Demeyer
Reviewer: Jeroen Demeyer, David Roe
Merged: sage-5.9.beta2
Issue created by migration from https://trac.sagemath.org/ticket/13062
The text was updated successfully, but these errors were encountered: