Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explict references to SAGE_ROOT in the doctesting framework #14331

Closed
ohanar opened this issue Mar 22, 2013 · 10 comments
Closed

remove explict references to SAGE_ROOT in the doctesting framework #14331

ohanar opened this issue Mar 22, 2013 · 10 comments
Assignees
Milestone

Comments

@ohanar
Copy link
Member

ohanar commented Mar 22, 2013

The new doctesting framework expects the sage library's source code to be in SAGE_ROOT/devel/sage which will no longer be the case once we switch layouts. Using the SAGE_SRC environment variable will make the transition much easier.

Apply attachment: trac14331.patch then attachment: trac14331_missed.patcho the sage library.

CC: @jdemeyer @roed314

Component: misc

Author: R. Andrew Ohana

Reviewer: David Roe

Merged: sage-5.9.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14331

@ohanar ohanar added this to the sage-5.9 milestone Mar 22, 2013
@ohanar
Copy link
Member Author

ohanar commented Mar 22, 2013

Attachment: trac14331.patch.gz

apply to sage library

@ohanar

This comment has been minimized.

@roed314
Copy link
Contributor

roed314 commented Mar 22, 2013

comment:2

Looks good to me.

@roed314
Copy link
Contributor

roed314 commented Mar 22, 2013

Reviewer: David Roe

@kiwifb
Copy link
Member

kiwifb commented Mar 24, 2013

comment:3

Definitely want this in. We didn't spend so much time on #13432 to be undone by the patch bomb from the new doctesting frame work. We want it ASAP. Thanks for spotting it Andrew and thanks for the review David.

Hopefully it doesn't interfere with any of the follow up of #12415.

@ohanar
Copy link
Member Author

ohanar commented Mar 24, 2013

Attachment: trac14331_missed.patch.gz

apply to sage library

@ohanar
Copy link
Member Author

ohanar commented Mar 24, 2013

comment:5

I missed one disguised reference in my first patch, so I've attached a fix for that.

@ohanar

This comment has been minimized.

@roed314
Copy link
Contributor

roed314 commented Mar 24, 2013

comment:6

Still looks fine.

@jdemeyer
Copy link

Merged: sage-5.9.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants