-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Cython 0.19 #14452
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
Robert, I think there is a serious Cython bug: the
generates
Note the call to the |
Upstream: Reported upstream. No feedback yet. |
This comment has been minimized.
This comment has been minimized.
comment:4
|
Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release. |
comment:5
Attachment: sage_crash_W7eVMu.log |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:7
Here is what I found about the docbuilder crash: it works with Cython 0.18, not with current master at In
which is compiled to
I don't see anything suspicious here. |
comment:8
Generating just |
comment:9
Robert, I feel like I can not do much more to debug the docbuilding since I don't really understand the mechanics of |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:13
I don't see anything suspicious there either. Can you try compiling lazy_import.pyx with -O0? What's the diff of this file between 0.18 and 0.19? |
comment:14
Replying to @robertwb:
I did, and it didn't help. I could try to bisect the Cython git repo for the bug. |
comment:15
Results of bisecting:
All commits in between simply fail to compile. |
comment:16
The relevant change seems to be the line
which was compiled in the good way as
and in the bad way as
|
comment:17
Alternatively, changing the line
to
also fixes the problem. I am applying this workaround in attachment: 14452_cython_0.19.patch. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Changed upstream from Fixed upstream, but not in a stable release. to None of the above - read trac for reasoning. |
spkg diff |
comment:21
Attachment: cython-0.19.p0.diff.gz |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:23
With these patches, all fine on the buildbot. |
Attachment: 14452_cython_0.19.patch.gz |
Dependencies: #13826 |
comment:24
Rebased to #13826. |
comment:26
Thanks for debugging this! I filed http://trac.cython.org/cython_trac/ticket/810 about (what I think is) the underlying bug you uncovered with the lazy import stuff. |
Merged: sage-5.9.rc0 |
Reviewer: Robert Bradshaw |
comment:28
Replying to @robertwb:
Do you have a better idea about what precisely is wrong? I isolated the problem, but I don't know why it segfaults. |
Upgrade to Cython 0.19.
spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/cython-0.19.p0.spkg (spkg diff)
upstream:
cpdef
keyword arguments inlazy_import.pyx
: http://trac.cython.org/cython_trac/ticket/810With this spkg, all doctests pass, but the docbuilder (in particular the command
./sage --docbuild reference/combinat html
) crashes due to a problem withlazy_import
: attachment: sage_crash_W7eVMu.log The Sage library patch works around this problem.On Itanium, there is a doctest failure
This is likely a bug in GCC-4.7.3, but no further investigation has been done. Compiling
sage/structure/element.pyx
with-Os
works around the problem, see patch.apply attachment: 14452_cython_0.19.patch
Depends on #13826
Upstream: None of the above - read trac for reasoning.
CC: @robertwb
Component: packages: standard
Author: Jeroen Demeyer
Reviewer: Robert Bradshaw
Merged: sage-5.9.rc0
Issue created by migration from https://trac.sagemath.org/ticket/14452
The text was updated successfully, but these errors were encountered: