Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lazy imports #19633

Closed
jdemeyer opened this issue Nov 27, 2015 · 24 comments
Closed

Optimize lazy imports #19633

jdemeyer opened this issue Nov 27, 2015 · 24 comments

Comments

@jdemeyer
Copy link

  1. make _get_object() a cpdef method again, like it was with Cython 0.18 and before, see Upgrade to Cython 0.19 #14452. This exposes a Python bug (incorrectly claimed to be a Cython bug) which needs to be fixed.

  2. use PyObject_RichCompare() as a shortcut in __richcmp__().

  3. use print syntax compatible with Python 3.

Upstream bug: http://bugs.python.org/issue25750

Upstream: Fixed upstream, but not in a stable release.

Component: misc

Author: Jeroen Demeyer

Branch: 308fa02

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19633

@jdemeyer jdemeyer added this to the sage-6.10 milestone Nov 27, 2015
@jdemeyer
Copy link
Author

Upstream: Reported upstream. No feedback yet.

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Small fixes to lazy imports Optimize lazy imports Nov 27, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Dependencies: #18542

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/19633

@jdemeyer
Copy link
Author

Commit: 901175d

@jdemeyer
Copy link
Author

New commits:

51ce428Add a sage --package update command
342efadUpdate to Python 2.7.10
901175dOptimize lazy import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 28, 2015

Changed commit from 901175d to bbd9eda

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 28, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bbd9edaOptimize lazy import

@jdemeyer
Copy link
Author

Changed dependencies from #18542 to none

@tscrim
Copy link
Collaborator

tscrim commented Nov 29, 2015

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 29, 2015

comment:11

Nearly trivial, but from my interpretation of the 3rd party packaging doc, we were suppose to have the first patched version be .p0? If we are suppose to be .p1, then you can set a positive review. Otherwise, you can set positive review after the appropriate change.

@jdemeyer
Copy link
Author

comment:12

I really don't think it matters if it's .p0 or .p1. But I'll change it because you ask.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

308fa02Optimize lazy import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2015

Changed commit from bbd9eda to 308fa02

@jdemeyer
Copy link
Author

Changed upstream from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

@vbraun
Copy link
Member

vbraun commented Nov 29, 2015

Changed branch from u/jdemeyer/ticket/19633 to 308fa02

@jdemeyer
Copy link
Author

jdemeyer commented Sep 8, 2018

Changed commit from 308fa02 to none

@jdemeyer
Copy link
Author

jdemeyer commented Sep 8, 2018

comment:16

Finally...

@jdemeyer
Copy link
Author

jdemeyer commented Sep 8, 2018

Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants