Change sage -p to always behave like sage -p -f

[jdemeyer]

Now that we have #19101, we should change sage -p (the low-level command to install a single package) to stop checking whether the package is already installed: all dependency checking should be moved to build/make/Makefile, used by sage -i.

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: 6a1d76b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19116

[jdemeyer]

Dependencies: #19101

[jdemeyer]

Branch: u/jdemeyer/change_sage__p_to_always_behave_like_sage__p__f

[jdemeyer]

New commits:

31ff6e7	Parse sage-spkg options in sage-spkg
cb05746	Add sage --location option to run sage-location
e856a8e	Change sage -i to install with dependencies
93ec09b	Change sage -p to always install a package

[jdemeyer]

Commit: 93ec09b

[tscrim]

comment:4

If -p is to always force a reinstall, then it doesn't behave the same as -i (and if I read your changes correctly, -p does not support the -f option). Would you be opposed to being explicit about -p and the options it supports in advanced?

[jdemeyer]

comment:5

Replying to @tscrim:

If -p is to always force a reinstall, then it doesn't behave the same as -i

Of course not. We wouldn't have two -i and -p options if they behaved the same.

I'll think about your "help" suggestion.

[sagetrac-git]

Changed commit from 93ec09b to c6ddd0e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c6ddd0e

Better help

[tscrim]

comment:7

Thanks.

[tscrim]

Reviewer: Travis Scrimshaw

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

f3d7ef3

Remove -f option to sage-spkg when running sage -i

[sagetrac-git]

Changed commit from c6ddd0e to f3d7ef3

[jdemeyer]

comment:9

I forgot an important and obviously needed fix. I hope the positive_review can stand.

[vbraun]

Changed branch from u/jdemeyer/change_sage__p_to_always_behave_like_sage__p__f to f3d7ef3

[vbraun]

Changed branch from f3d7ef3 to u/jdemeyer/change_sage__p_to_always_behave_like_sage__p__f

[vbraun]

comment:11

Reopening because of #19104

[jdemeyer]

Changed dependencies from #19101 to #19101, #19104

[sagetrac-git]

Changed commit from f3d7ef3 to 6a1d76b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4eb1aa8	Restore SAGE_INSTALL_FETCH_ONLY support
6a1d76b	Merge #19104

[jdemeyer]

comment:18

Thanks! I am making this a blocker because it is an important user interface change which is best merged in the same release as #19101.

[tscrim]

comment:19

Sorry for taking so long to get back to this. However there seems to be a conflict with the latest beta.

[jdemeyer]

comment:20

Replying to @tscrim:

Sorry for taking so long to get back to this. However there seems to be a conflict with the latest beta.

It merges cleanly for me...

[jdemeyer]

Changed dependencies from #19101, #19104 to none

[vbraun]

Changed branch from u/jdemeyer/change_sage__p_to_always_behave_like_sage__p__f to 6a1d76b