Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PKG-clean target to implement sage -f PKG #19119

Closed
jdemeyer opened this issue Sep 1, 2015 · 12 comments
Closed

Use PKG-clean target to implement sage -f PKG #19119

jdemeyer opened this issue Sep 1, 2015 · 12 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Sep 1, 2015

After #19101, sage -f PKG first deletes local/var/lib/sage/installed/PKG-* and then runs sage -i PKG.

I propose to move the rule of removing local/var/lib/sage/installed/PKG-* to build/make/Makefile as a PKG-clean target. This would make it easier to extend the functionality of sage -f FOO to non-packages, for example

sage -f optional   # force install all optional packages
sage -f python     # force install correct version of Python (python2 or python3 package)

Depends on #19116

Component: build

Author: Jeroen Demeyer

Branch/Commit: 1812e4f

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/19119

@jdemeyer jdemeyer added this to the sage-6.9 milestone Sep 1, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Sep 1, 2015

Branch: u/jdemeyer/ticket/19119

@jdemeyer
Copy link
Author

jdemeyer commented Sep 1, 2015

New commits:

31ff6e7Parse sage-spkg options in sage-spkg
cb05746Add sage --location option to run sage-location
e856a8eChange sage -i to install with dependencies
93ec09bChange sage -p to always install a package
c6ddd0eBetter help
f3d7ef3Remove -f option to sage-spkg when running sage -i
752e269Use PKG-clean target to implement sage -f PKG

@jdemeyer
Copy link
Author

jdemeyer commented Sep 1, 2015

Commit: 752e269

@jdemeyer jdemeyer changed the title Use $PKG-clean target to implement sage -f $PKG Use PKG-clean target to implement sage -f PKG Sep 1, 2015
@jhpalmieri
Copy link
Member

comment:3

If I run sage -i python or sage -f python, I get

Error: package 'python' not found
Assuming it is an old-style package... (this is deprecated: use -p instead of -i to install old-style packages)

Attempting to download package python
Error: could not find a package matching python
       Try 'sage --package list' to see the available packages
       Did you mean: cython, ipython, python2, python3, patch?

If I run make python, I get

make[1]: *** No rule to make target `python'.  Stop.

This is despite the line

PYTHON = $(PYTHON2)

in build/make/Makefile.

@jhpalmieri
Copy link
Member

comment:4

Or maybe that's not the point of this ticket, and this just adds PKG-clean. That part works well.

@jhpalmieri
Copy link
Member

comment:5

Although should make PKG-clean also delete the log file for PKG?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

1812e4fMerge tag '6.9.beta6' into t/19119/ticket/19119

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2015

Changed commit from 752e269 to 1812e4f

@jdemeyer
Copy link
Author

comment:7

Replying to @jhpalmieri:

Or maybe that's not the point of this ticket, and this just adds PKG-clean.

Exactly.

@jdemeyer
Copy link
Author

comment:8

Replying to @jhpalmieri:

Although should make PKG-clean also delete the log file for PKG?

I don't see why... so far Sage has always appended log files and I see no reason to change that on this ticket.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@vbraun
Copy link
Member

vbraun commented Sep 11, 2015

Changed branch from u/jdemeyer/ticket/19119 to 1812e4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants