-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage_bootstrap: Remove purported Python 2.6 support #20023
Comments
comment:1
I changed the directory to ` There is no subdirectory named "compat". |
comment:2
This can also help with #9536 since Python 2.7+ supports the |
Dependencies: #19984 |
This comment has been minimized.
This comment has been minimized.
comment:5
See #28000 for complete removal of Python 2 support. |
comment:6
I'm pretty sure Python 2.6 support is completely removed from sagelib itself, just not from sage_bootstrap. |
comment:7
should we clean up |
comment:8
Removing the ability to bootstrap from Python 2.6 probably does |
comment:9
From the brief look at the code, this is a change that may be done now, and after all noone must Python 2.6 now. |
comment:10
It's the default python on redhat/centos 6 and possibly some ancient debian. I'll note that redhat/centos 6 have access to newer python but someone with admin privileges and knowledge of software collections is needed. |
comment:12
I'll make an experimental branch to remove vendored argparse |
Author: Dima Pasechnik |
Commit: |
Branch: u/dimpase/build/unvendorargparse |
New commits:
|
Changed dependencies from #19984 to none |
comment:14
tests run on https://github.com/dimpase/sage/pull/11 |
comment:16
Also need to update |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Changed reviewer from Matthias Koeppe to Matthias Koeppe, ... |
comment:39
should we also remove |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:41
OK, this works |
Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Dima Pasechnik |
comment:42
Thanks. |
comment:43
Merge conflict |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed branch from u/mkoeppe/build/unvendorargparse to |
centos-6
no longer worksIn this ticket, we
sage_bootstrap/compat/argparse.py
This is on top of #31419 so that we have to change
README
only once.Depends on #29890
Depends on #31419
Depends on #31318
CC: @fchapoton @dimpase @embray @kiwifb @jdemeyer @slel @jhpalmieri
Component: build
Author: Dima Pasechnik, Matthias Koeppe
Branch/Commit:
8cd0bcc
Reviewer: Matthias Koeppe, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/20023
The text was updated successfully, but these errors were encountered: