Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python to 3.9.2 #31419

Closed
mkoeppe opened this issue Feb 20, 2021 · 17 comments
Closed

Update python to 3.9.2 #31419

mkoeppe opened this issue Feb 20, 2021 · 17 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Feb 20, 2021

https://docs.python.org/3/whatsnew/changelog.html#python-3-9-2-final

CC: @kiwifb @antonio-rojas @slel

Component: packages: standard

Keywords: upgrade, python

Author: Matthias Koeppe

Branch/Commit: 5e810dd

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31419

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 20, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2021

Branch: u/mkoeppe/update_python_to_3_9_2

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2021

Commit: 5e810dd

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2021

New commits:

5e810ddbuild/pkgs/python3: Update to 3.9.2

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 21, 2021

@slel
Copy link
Member

slel commented Feb 21, 2021

comment:5

Any way to base this on top of #31344?

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 21, 2021

comment:6

Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344 and then merge it in, using git merge FETCH_HEAD.

@slel
Copy link
Member

slel commented Feb 24, 2021

Changed keywords from none to upgrade, python

@slel
Copy link
Member

slel commented Feb 24, 2021

comment:7

Replying to @mkoeppe:

Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344 and then merge it in, using git merge FETCH_HEAD.

I tested as follows.

Set up a new clone with tricks to save time and bandwidth:

$ ORIG=sage.git  # local mirror of https://github.com/sagemath/sage.git
$ DEST=sage93c  # name for new clone
$ UPST=$(pwd)/sage-upstream  # common upstream folder for several clones
$ git clone --single-branch --branch develop --tags $ORIG $DEST  # clone locally
$ cd $DEST
$ ln -s $UPST ./upstream  # use common upstream folder to download less 
$ git remote add trac git://trac.sagemath.org/sage.git -t develop

Follow your advice:

$ git trac checkout 31419
$ git trac fetch 31344
$ git merge FETCH_HEAD

Build and test:

$ source .homebrew-build-env
$ ./bootstrap -q
$ ./configure --enable-download-from-upstream-url -q
$ make -s V=0
$ make -s V=0 testlong

The build succeeds but make testlong gives:

----------------------------------------------------------------------
sage -t --long src/sage/interfaces/singular.py  # Killed due to segmentation fault
sage -t --long src/sage/interfaces/mwrank.py  # 4 doctests failed
sage -t --long src/sage/interfaces/gap.py  # 7 doctests failed
----------------------------------------------------------------------

When run again separately (with ./sage -t --long), the tests

  • pass for src/sage/interfaces/singular.py and src/sage/interfaces/mwrank.py
  • keep failing for src/sage/interfaces/gap.py

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 24, 2021

comment:8

I don't think these doctest failures are related to this update

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 24, 2021

comment:9

Replying to @slel:

I tested as follows.

Set up a new clone with tricks to save time and bandwidth:

$ ORIG=sage.git  # local mirror of https://github.com/sagemath/sage.git
$ DEST=sage93c  # name for new clone
...
$ git clone --single-branch --branch develop --tags $ORIG $DEST  # clone locally

Even easier is to use (cd $ORIG && git worktree add $DEST)

@dimpase
Copy link
Member

dimpase commented Feb 27, 2021

comment:10

all good in view of
https://github.com/mkoeppe/sage/actions/runs/584631860

@dimpase
Copy link
Member

dimpase commented Feb 27, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/584631860, ... to Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 27, 2021

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/mkoeppe/update_python_to_3_9_2 to 5e810dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants