Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recognizable series: hash, comparison, TestSuite #21319

Closed
dkrenn opened this issue Aug 23, 2016 · 50 comments
Closed

recognizable series: hash, comparison, TestSuite #21319

dkrenn opened this issue Aug 23, 2016 · 50 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Aug 23, 2016

  • Implement hashing and comparison.
  • Make TestSuite pass all tests.

See also meta ticket #21202.

Depends on #21325
Depends on #21336

CC: @galipnik

Component: combinatorics

Author: Daniel Krenn

Branch/Commit: a7ecb88

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/21319
@dkrenn dkrenn added this to the sage-7.4 milestone Aug 23, 2016
@dkrenn

This comment has been minimized.

Sign in to view
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Dependencies: #21318

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Branch: u/dkrenn/sequences/rec-basic-arith

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Changed branch from u/dkrenn/sequences/rec-basic-arith to none

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Branch: u/dkrenn/sequences/rec-hash

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

01495cbextend to negative shifts in subsequence
b76bf4efactor out subsequence to separat ticket
5919120doctesting all parameters in coefficient_of_word
c7243a6Merge tag '7.4.beta1' into t/21295/sequences/recognizable
4012778Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
5dbedabfix doctests (experimental warning)
143ea73fix building of docs (no idea why it failed)
6247a7fMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
ffe5f90Merge branch 't/21318/sequences/rec-basic-arith' into t/21319/sequences/rec-hash

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Commit: ffe5f90

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Changed commit from ffe5f90 to a4ccbec

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

a8e6334MatrixSpace.some_elements
520aaf1FreeModule_generic.some_elements
5afda8eMerge branch 'u/dkrenn/matrices-some-elements' into t/21319/sequences/rec-hash
1e5754ban_element and some_elements
becce48pickling support
a4ccbecTestSuite

@dkrenn

This comment has been minimized.

Sign in to view
@dkrenn dkrenn changed the title recognizable series: hash, comparison recognizable series: hash, comparison, TestSuite Aug 25, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 25, 2016

Changed dependencies from #21318 to #21318, #21336

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Changed commit from a4ccbec to c2f9c62

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

41bc288quasi-cherry-pick of pad_right of k-regular-guess branch
3023233rewrite to make subsequence more efficient (dynamically add kernel)
51e7d72minor rewrite
9311636allow b to be a dict
624e6c0forward/backward difference
45d9e67minor rewrites
c430158partial sums
7eb93e1minor rewrites to use existing stuff better
0f89159Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
c2f9c62Merge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 25, 2016

Changed dependencies from #21318, #21336 to #21318, #21325, #21336

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 25, 2016

comment:10

Merged #21325 to avoid a (trivial) merge conflict.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

e03a32fMerge tag '7.4.beta2' into t/21180/cantor_product_comb
642cceeMerge branch 't/21180/cantor_product_comb' into t/21203/sequences/k-regular
352751eMerge tag '7.4.beta2' into t/21295/sequences/recognizable
914640fMerge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
c0ade99Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
35807dfMerge branch 't/21318/sequences/rec-basic-arith' into t/21319/sequences/rec-hash
a2fe6f3Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
e4cec17minor correction in doc
3a4e849Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
c8a86dbMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from c2f9c62 to c8a86db

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2016

Changed commit from c8a86db to 18c5268

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

18c5268correct typo in docstring

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

comment:13

doctest failures (cf. patchbot), patchbot python3 warning.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

4970cf5Python3: absolute import
e33a3c9Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
4da9796Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
13b536ePython3: absolut import
5919c4dMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
9086b64Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
fc6c3f5Python3: xrange
714276cMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
457aefdPython3: fix iteritems
fcb53a3fix doctest output of TestSuite (new tests were added)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Changed commit from 18c5268 to fcb53a3

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2022

Changed commit from 9fefcce to 671dd66

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0d0142aTrac #21319: fix RESt issues
dec24acTrac #21319: replace "recognizable series" by "recognizable series space"
671dd66Trac #21319: PEP8

@cheuberg
Copy link
Contributor

comment:28

I reviewed the ticket and pushed three reviewer commits, please cross-review.

Some minor remarks:

  1. Please fix pyflakes issues outlined by the patchbot plugin

  2. RecognizableSeries.__eq__, last test: what is supposed to happen here? Is x defined?

  3. RecognizableSeries.__ne__, one-sentence description: I think that the one-sentence description has been copied from __eq__ unchanged.

@fchapoton
Copy link
Contributor

Changed commit from 671dd66 to a7ecb88

@fchapoton
Copy link
Contributor

Changed branch from u/cheuberg/sequences/rec-hash to public/ticket/21319

@fchapoton
Copy link
Contributor

comment:30

I have fixed the details from :comment:28

New commits:

32eefceMerge branch 'u/cheuberg/sequences/rec-hash' in 9.6.b6
a7ecb88reviewer's commit

@cheuberg
Copy link
Contributor

cheuberg commented Apr 2, 2022

comment:31

@fchapoton: Thank you for fixing these issues. From my side, everything is fine now; the question is whether you reviewed my reviewer commits ​0d0142a, dec24ac, 671dd66, in which case this ticket could be set to positive.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 17, 2022
@galipnik
Copy link

galipnik commented May 3, 2022

comment:33

I have reviewed the commits ​0d0142a, dec24ac, 671dd66; the changes look good to me.

@cheuberg
Copy link
Contributor

cheuberg commented May 6, 2022

comment:34

Replying to @galipnik:

I have reviewed the commits ​0d0142a, dec24ac, 671dd66; the changes look good to me.

Thank you. So everything is done and reviewed here. I am setting to positive.

@dkrenn
Copy link
Contributor Author

dkrenn commented May 6, 2022

comment:35

Thank you all; had a quick look at the reviewing commits; LGTM and I am happy with its current status positive_review :)

@vbraun
Copy link
Member

vbraun commented May 17, 2022

Changed branch from public/ticket/21319 to a7ecb88

@vbraun vbraun closed this as completed in f723fbb May 17, 2022
This was referenced Dec 29, 2022
Open
Closed
@galipnik galipnik mentioned this issue Sep 25, 2022
Closed
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
e726278 
…gular-guess

* t/21319/sequences/rec-hash: (11520 commits)
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  Trac sagemath#21203 review issue 1: better binary sum of digits
  Trac sagemath#21203 review issue 5: meaningful error message in _n_to_index_
  Trac sagemath#21203 review issue 8: resolve "`n`th" in docstring
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
5ce5276 
…gular-guess

* t/21319/sequences/rec-hash:
  Trac sagemath#21319: fix punctuation
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: fixup test .subsequence being identity
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: use (new) decorator minimize_result
  Trac sagemath#21325: remove empty lines, fix punctuation
  Trac sagemath#21325: remove iteritems
  Trac sagemath#21318: fix rmul/lmul issues
  Trac sagemath#21318: use "correct" 1
  Trac sagemath#21318: use tensor_product in method hadamard_product
  Trac sagemath#21318: use is_trivial_zero in doctest of _neg_
  Trac sagemath#21318: use (new) .linear_representation in doctests
  Trac sagemath#21318: fix empty lines and punctuation
  Trac sagemath#21318: decorator minimize_result
  Trac sagemath#21203 review issue 10: use "raise ... from None" where approriate
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
8488b55 
…ar-warning

* t/21204/sequences/k-regular-guess: (11522 commits)
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  Trac sagemath#21203 review issue 1: better binary sum of digits
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
fb5fb62 
…ar-warning

* t/21204/sequences/k-regular-guess:
  Trac sagemath#21204: fix punctuation
  Trac sagemath#21319: fix punctuation
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: fixup test .subsequence being identity
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: use (new) decorator minimize_result
  Trac sagemath#21325: remove empty lines, fix punctuation
  Trac sagemath#21325: remove iteritems
  Trac sagemath#21318: fix rmul/lmul issues
  Trac sagemath#21318: use "correct" 1
  Trac sagemath#21318: use tensor_product in method hadamard_product
  Trac sagemath#21318: use is_trivial_zero in doctest of _neg_
  Trac sagemath#21318: use (new) .linear_representation in doctests
  Trac sagemath#21318: fix empty lines and punctuation
  Trac sagemath#21318: decorator minimize_result
  Trac sagemath#21203 review issue 10: use "raise ... from None" where approriate
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 't/21343/k-regular-warning' into t/22964/k-regular-bounded
b44bdad 
* t/21343/k-regular-warning: (11523 commits)
  Trac sagemath#21343: adapt to removed transpose-property in dependency
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
7 participants
@vbraun @dimpase @fchapoton @mkoeppe @cheuberg @dkrenn @galipnik